Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ReVanced crashes when restarting to apply setting #2312

Closed
CnC-Robert opened this issue Jul 31, 2022 · 2 comments · Fixed by ReVanced/revanced-patches-template#260
Closed
Labels
Bug report Something isn't working

Comments

@CnC-Robert
Copy link
Member

Type

Error at runtime

Bug description

When restarting to apply a setting, the app crashes seemingly at random.
I have not been able to find a pattern for when it happens.

Steps to reproduce

  1. Open the settings menu
  2. Change a setting that requires a restart
  3. Click restart
  4. Repeat until the app crashes

Relevant log output

07-31 19:11:02.700 16281 16281 D AndroidRuntime: Shutting down VM
07-31 19:11:02.701 16281 16281 E AndroidRuntime: FATAL EXCEPTION: main
07-31 19:11:02.701 16281 16281 E AndroidRuntime: Process: app.revanced.android.youtube, PID: 16281
07-31 19:11:02.701 16281 16281 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Class.getName()' on a null object reference
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.content.ComponentName.<init>(ComponentName.java:133)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.content.Intent.<init>(Intent.java:7117)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment.reboot(ReVancedSettingsFragment.java:213)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment.lambda$rebootDialog$2$app-revanced-integrations-settingsmenu-ReVancedSettingsFragment(ReVancedSettingsFragment.java:218)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:4)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:175)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:201)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7870)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Screenshots or videos

screen-20220731-191836.mp4

Solution

I don't know

Additional context

No response

@CnC-Robert CnC-Robert added the Bug report Something isn't working label Jul 31, 2022
@Sculas Sculas linked a pull request Jul 31, 2022 that will close this issue
@Sculas
Copy link
Contributor

Sculas commented Jul 31, 2022

@TheJeterLP
Copy link

@oSumAtrIX Any idea why homeActivityClass is never being set?

https://github.com/revanced/revanced-integrations/blob/d7833ec2e7c82104c3c567a7e55cb388a71bd9f0/app/src/main/java/app/revanced/integrations/settingsmenu/ReVancedSettingsFragment.java#L34

Probably that was set by vanced somewhere in bytecode. Should be an easy fix

@Sculas Sculas closed this as completed Jul 31, 2022
@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@alexandreteles alexandreteles transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.175.0](ReVanced/revanced-patches@v2.174.0...v2.175.0) (2023-05-31)

### Bug Fixes

* **settings:** sort setting preferences using lowercase ([ReVanced#2312](ReVanced/revanced-patches#2312)) ([2743a95](ReVanced/revanced-patches@38e433d))
* **spoof-wifi-connection:** use updated instruction indices ([ReVanced#2199](ReVanced/revanced-patches#2199)) ([76fb700](ReVanced/revanced-patches@815f764))
* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@238f7f2))
* **youtube/hide-info-cards:** fix hide-info-cards setting does not work ([ReVanced#2246](ReVanced/revanced-patches#2246)) ([72773ac](ReVanced/revanced-patches@5163022))
* **youtube/hide-player-buttons:** fix previous/next button showing if previous video exists ([ReVanced#2261](ReVanced/revanced-patches#2261)) ([91d1aab](ReVanced/revanced-patches@258c550))
* **youtube/hide-shorts-components:** clarify settings switch ([ReVanced#2276](ReVanced/revanced-patches#2276)) ([3e6d052](ReVanced/revanced-patches@8caa103))
* **youtube/integrations:** fix playback of embedded videos ([ReVanced#2304](ReVanced/revanced-patches#2304)) ([1dffbaf](ReVanced/revanced-patches@ec8c4e2))
* **youtube/remember-video-quality:** fix typo in video resolutions ([ReVanced#2323](ReVanced/revanced-patches#2323)) ([a99cef8](ReVanced/revanced-patches@8d58d48))
* **youtube/remove-player-controls-background:** use correct patch name and description ([8732a84](ReVanced/revanced-patches@a8ca870))
* **youtube/theme:** use dynamic background color for custom splash screen ([ReVanced#2319](ReVanced/revanced-patches#2319)) ([28594f3](ReVanced/revanced-patches@4552fe7))

### Features

* **nfctoolsse:** add `unlock-pro` patch ([ReVanced#2272](ReVanced/revanced-patches#2272)) ([9789ad3](ReVanced/revanced-patches@a107e1e))
* **remove-screen-capture-restriction:** remove app constraint ([ReVanced#2260](ReVanced/revanced-patches#2260)) ([49ce47c](ReVanced/revanced-patches@ee1d7fb))
* **scbeasy:** add `remove-debugging-detection` patch ([ReVanced#2287](ReVanced/revanced-patches#2287)) ([53d91e3](ReVanced/revanced-patches@1fc06ff))
* **tiktok:** remove compatibility version constraints ([ReVanced#2306](ReVanced/revanced-patches#2306)) ([a12c4bb](ReVanced/revanced-patches@86a4867))
* **youtube/general-ads:** merge `hide-get-premium` patch into `general-ads` patch ([5195dd8](ReVanced/revanced-patches@2a88347))
* **youtube/hide-seekbar:** more fine grained hiding of seekbar ([ReVanced#2252](ReVanced/revanced-patches#2252)) ([0f07bf4](ReVanced/revanced-patches@5d39f64))
* **youtube/hide-shorts-components:** hide channel bar & sound button ([749c83d](ReVanced/revanced-patches@7ef8526))
* **youtube/hide-shorts-components:** hide shorts info panel ([ReVanced#2278](ReVanced/revanced-patches#2278)) ([a5b323d](ReVanced/revanced-patches@dc28b9a))
* **youtube/navigation-buttons:** use a better preference screen title ([5d7772b](ReVanced/revanced-patches@ecc70ad))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.175.0](ReVanced/revanced-patches@v2.174.0...v2.175.0) (2023-05-31)

### Bug Fixes

* **settings:** sort setting preferences using lowercase ([ReVanced#2312](ReVanced/revanced-patches#2312)) ([2743a95](ReVanced/revanced-patches@2743a95))
* **spoof-wifi-connection:** use updated instruction indices ([ReVanced#2199](ReVanced/revanced-patches#2199)) ([76fb700](ReVanced/revanced-patches@76fb700))
* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@4480911))
* **youtube/hide-info-cards:** fix hide-info-cards setting does not work ([ReVanced#2246](ReVanced/revanced-patches#2246)) ([72773ac](ReVanced/revanced-patches@72773ac))
* **youtube/hide-player-buttons:** fix previous/next button showing if previous video exists ([ReVanced#2261](ReVanced/revanced-patches#2261)) ([91d1aab](ReVanced/revanced-patches@91d1aab))
* **youtube/hide-shorts-components:** clarify settings switch ([ReVanced#2276](ReVanced/revanced-patches#2276)) ([3e6d052](ReVanced/revanced-patches@3e6d052))
* **youtube/integrations:** fix playback of embedded videos ([ReVanced#2304](ReVanced/revanced-patches#2304)) ([1dffbaf](ReVanced/revanced-patches@1dffbaf))
* **youtube/remember-video-quality:** fix typo in video resolutions ([ReVanced#2323](ReVanced/revanced-patches#2323)) ([a99cef8](ReVanced/revanced-patches@a99cef8))
* **youtube/remove-player-controls-background:** use correct patch name and description ([8732a84](ReVanced/revanced-patches@8732a84))
* **youtube/theme:** use dynamic background color for custom splash screen ([ReVanced#2319](ReVanced/revanced-patches#2319)) ([28594f3](ReVanced/revanced-patches@28594f3))

### Features

* **nfctoolsse:** add `unlock-pro` patch ([ReVanced#2272](ReVanced/revanced-patches#2272)) ([9789ad3](ReVanced/revanced-patches@9789ad3))
* **remove-screen-capture-restriction:** remove app constraint ([ReVanced#2260](ReVanced/revanced-patches#2260)) ([49ce47c](ReVanced/revanced-patches@49ce47c))
* **scbeasy:** add `remove-debugging-detection` patch ([ReVanced#2287](ReVanced/revanced-patches#2287)) ([53d91e3](ReVanced/revanced-patches@53d91e3))
* **tiktok:** remove compatibility version constraints ([ReVanced#2306](ReVanced/revanced-patches#2306)) ([a12c4bb](ReVanced/revanced-patches@a12c4bb))
* **youtube/general-ads:** merge `hide-get-premium` patch into `general-ads` patch ([5195dd8](ReVanced/revanced-patches@5195dd8))
* **youtube/hide-seekbar:** more fine grained hiding of seekbar ([ReVanced#2252](ReVanced/revanced-patches#2252)) ([0f07bf4](ReVanced/revanced-patches@0f07bf4))
* **youtube/hide-shorts-components:** hide channel bar & sound button ([749c83d](ReVanced/revanced-patches@749c83d))
* **youtube/hide-shorts-components:** hide shorts info panel ([ReVanced#2278](ReVanced/revanced-patches#2278)) ([a5b323d](ReVanced/revanced-patches@a5b323d))
* **youtube/navigation-buttons:** use a better preference screen title ([5d7772b](ReVanced/revanced-patches@5d7772b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants