Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tasteBuilder-remover patch failes in 5.17.51 YTMusic #2274

Closed
shivanshvermak opened this issue Aug 7, 2022 · 2 comments
Closed

bug: tasteBuilder-remover patch failes in 5.17.51 YTMusic #2274

shivanshvermak opened this issue Aug 7, 2022 · 2 comments
Labels
Bug report Something isn't working

Comments

@shivanshvermak
Copy link

Type

Error while patching

Bug description

CLI: v2.9.1
Patches: v2.33.0
Integrations: v0.31.1
YTMusic version: 5.17.51

Steps to reproduce

Just try patching YTMusic using CLI, tastebuilder patch fails.

Relevant log output

SEVERE: tasteBuilder-remover failed:
app.revanced.patcher.patch.PatchResultError: taste-builder-constructor-fingerprint has not been resolved yet.
        at app.revanced.patcher.Patcher.applyPatch(Patcher.kt:301)
        at app.revanced.patcher.Patcher.access$applyPatch(Patcher.kt:44)
        at app.revanced.patcher.Patcher$applyPatches$1.invokeSuspend(Patcher.kt:317)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:127)
        at app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:92)
        at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:22)
        at app.revanced.cli.command.MainCommand.run(MainCommand.kt:160)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1939)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2358)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2314)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2316)
        at picocli.CommandLine.execute(CommandLine.java:2078)
        at app.revanced.cli.main.MainKt.main(Main.kt:7)
Caused by: java.lang.Exception: taste-builder-constructor-fingerprint has not been resolved yet.
        at app.revanced.patcher.fingerprint.method.impl.MethodFingerprint.getResult(MethodFingerprint.kt:37)
        at app.revanced.patches.music.layout.tastebuilder.patch.RemoveTasteBuilderPatch.execute(RemoveTasteBuilderPatch.kt:27)
        at app.revanced.patches.music.layout.tastebuilder.patch.RemoveTasteBuilderPatch.execute(RemoveTasteBuilderPatch.kt:16)
        at app.revanced.patcher.Patcher.applyPatch(Patcher.kt:296)
        ... 16 more

Screenshots or videos

image

Solution

No response

Additional context

No response

@shivanshvermak shivanshvermak added the Bug report Something isn't working label Aug 7, 2022
@shivanshvermak shivanshvermak changed the title bug: tastebuilder patch failes in 5.17.51 YTMusic bug: tasteBuilder-remover patch failes in 5.17.51 YTMusic Aug 7, 2022
@oSumAtrIX
Copy link
Member

@EpicSampler Was this tested?

@ghost
Copy link

ghost commented Aug 7, 2022

@shivanshkverma In case you used the --experimental flag - leave it off (5.17.51 is supported now) and you should not run into this error

@oSumAtrIX

Was this tested?

tastebuilder patch doesn't support 5.17 for a reason, note from PR:
c303589#diff-03aa6ead4b178e9383c573664048494ca55312f11a292185015ce899ee44c1adR6-R10

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@alexandreteles alexandreteles transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.175.0-dev.4](ReVanced/revanced-patches@v2.175.0-dev.3...v2.175.0-dev.4) (2023-05-26)

### Bug Fixes

* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@238f7f2))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.175.0](ReVanced/revanced-patches@v2.174.0...v2.175.0) (2023-05-31)

### Bug Fixes

* **settings:** sort setting preferences using lowercase ([ReVanced#2312](ReVanced/revanced-patches#2312)) ([2743a95](ReVanced/revanced-patches@38e433d))
* **spoof-wifi-connection:** use updated instruction indices ([ReVanced#2199](ReVanced/revanced-patches#2199)) ([76fb700](ReVanced/revanced-patches@815f764))
* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@238f7f2))
* **youtube/hide-info-cards:** fix hide-info-cards setting does not work ([ReVanced#2246](ReVanced/revanced-patches#2246)) ([72773ac](ReVanced/revanced-patches@5163022))
* **youtube/hide-player-buttons:** fix previous/next button showing if previous video exists ([ReVanced#2261](ReVanced/revanced-patches#2261)) ([91d1aab](ReVanced/revanced-patches@258c550))
* **youtube/hide-shorts-components:** clarify settings switch ([ReVanced#2276](ReVanced/revanced-patches#2276)) ([3e6d052](ReVanced/revanced-patches@8caa103))
* **youtube/integrations:** fix playback of embedded videos ([ReVanced#2304](ReVanced/revanced-patches#2304)) ([1dffbaf](ReVanced/revanced-patches@ec8c4e2))
* **youtube/remember-video-quality:** fix typo in video resolutions ([ReVanced#2323](ReVanced/revanced-patches#2323)) ([a99cef8](ReVanced/revanced-patches@8d58d48))
* **youtube/remove-player-controls-background:** use correct patch name and description ([8732a84](ReVanced/revanced-patches@a8ca870))
* **youtube/theme:** use dynamic background color for custom splash screen ([ReVanced#2319](ReVanced/revanced-patches#2319)) ([28594f3](ReVanced/revanced-patches@4552fe7))

### Features

* **nfctoolsse:** add `unlock-pro` patch ([ReVanced#2272](ReVanced/revanced-patches#2272)) ([9789ad3](ReVanced/revanced-patches@a107e1e))
* **remove-screen-capture-restriction:** remove app constraint ([ReVanced#2260](ReVanced/revanced-patches#2260)) ([49ce47c](ReVanced/revanced-patches@ee1d7fb))
* **scbeasy:** add `remove-debugging-detection` patch ([ReVanced#2287](ReVanced/revanced-patches#2287)) ([53d91e3](ReVanced/revanced-patches@1fc06ff))
* **tiktok:** remove compatibility version constraints ([ReVanced#2306](ReVanced/revanced-patches#2306)) ([a12c4bb](ReVanced/revanced-patches@86a4867))
* **youtube/general-ads:** merge `hide-get-premium` patch into `general-ads` patch ([5195dd8](ReVanced/revanced-patches@2a88347))
* **youtube/hide-seekbar:** more fine grained hiding of seekbar ([ReVanced#2252](ReVanced/revanced-patches#2252)) ([0f07bf4](ReVanced/revanced-patches@5d39f64))
* **youtube/hide-shorts-components:** hide channel bar & sound button ([749c83d](ReVanced/revanced-patches@7ef8526))
* **youtube/hide-shorts-components:** hide shorts info panel ([ReVanced#2278](ReVanced/revanced-patches#2278)) ([a5b323d](ReVanced/revanced-patches@dc28b9a))
* **youtube/navigation-buttons:** use a better preference screen title ([5d7772b](ReVanced/revanced-patches@ecc70ad))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.175.0-dev.4](ReVanced/revanced-patches@v2.175.0-dev.3...v2.175.0-dev.4) (2023-05-26)

### Bug Fixes

* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@4480911))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.175.0](ReVanced/revanced-patches@v2.174.0...v2.175.0) (2023-05-31)

### Bug Fixes

* **settings:** sort setting preferences using lowercase ([ReVanced#2312](ReVanced/revanced-patches#2312)) ([2743a95](ReVanced/revanced-patches@2743a95))
* **spoof-wifi-connection:** use updated instruction indices ([ReVanced#2199](ReVanced/revanced-patches#2199)) ([76fb700](ReVanced/revanced-patches@76fb700))
* **youtube/downloads:** rename patch to `external-downloads` ([ReVanced#2274](ReVanced/revanced-patches#2274)) ([4480911](ReVanced/revanced-patches@4480911))
* **youtube/hide-info-cards:** fix hide-info-cards setting does not work ([ReVanced#2246](ReVanced/revanced-patches#2246)) ([72773ac](ReVanced/revanced-patches@72773ac))
* **youtube/hide-player-buttons:** fix previous/next button showing if previous video exists ([ReVanced#2261](ReVanced/revanced-patches#2261)) ([91d1aab](ReVanced/revanced-patches@91d1aab))
* **youtube/hide-shorts-components:** clarify settings switch ([ReVanced#2276](ReVanced/revanced-patches#2276)) ([3e6d052](ReVanced/revanced-patches@3e6d052))
* **youtube/integrations:** fix playback of embedded videos ([ReVanced#2304](ReVanced/revanced-patches#2304)) ([1dffbaf](ReVanced/revanced-patches@1dffbaf))
* **youtube/remember-video-quality:** fix typo in video resolutions ([ReVanced#2323](ReVanced/revanced-patches#2323)) ([a99cef8](ReVanced/revanced-patches@a99cef8))
* **youtube/remove-player-controls-background:** use correct patch name and description ([8732a84](ReVanced/revanced-patches@8732a84))
* **youtube/theme:** use dynamic background color for custom splash screen ([ReVanced#2319](ReVanced/revanced-patches#2319)) ([28594f3](ReVanced/revanced-patches@28594f3))

### Features

* **nfctoolsse:** add `unlock-pro` patch ([ReVanced#2272](ReVanced/revanced-patches#2272)) ([9789ad3](ReVanced/revanced-patches@9789ad3))
* **remove-screen-capture-restriction:** remove app constraint ([ReVanced#2260](ReVanced/revanced-patches#2260)) ([49ce47c](ReVanced/revanced-patches@49ce47c))
* **scbeasy:** add `remove-debugging-detection` patch ([ReVanced#2287](ReVanced/revanced-patches#2287)) ([53d91e3](ReVanced/revanced-patches@53d91e3))
* **tiktok:** remove compatibility version constraints ([ReVanced#2306](ReVanced/revanced-patches#2306)) ([a12c4bb](ReVanced/revanced-patches@a12c4bb))
* **youtube/general-ads:** merge `hide-get-premium` patch into `general-ads` patch ([5195dd8](ReVanced/revanced-patches@5195dd8))
* **youtube/hide-seekbar:** more fine grained hiding of seekbar ([ReVanced#2252](ReVanced/revanced-patches#2252)) ([0f07bf4](ReVanced/revanced-patches@0f07bf4))
* **youtube/hide-shorts-components:** hide channel bar & sound button ([749c83d](ReVanced/revanced-patches@749c83d))
* **youtube/hide-shorts-components:** hide shorts info panel ([ReVanced#2278](ReVanced/revanced-patches#2278)) ([a5b323d](ReVanced/revanced-patches@a5b323d))
* **youtube/navigation-buttons:** use a better preference screen title ([5d7772b](ReVanced/revanced-patches@5d7772b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants