Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 19.04.37 YouTube Auto-repeat / Loop patch always active, can't disable #2699

Closed
3 tasks done
TheShadowRunner opened this issue Feb 7, 2024 · 3 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@TheShadowRunner
Copy link

TheShadowRunner commented Feb 7, 2024

Bug description

Revanced YouTube 19.04.37 and the Auto-repeat" patch.

After enabling it at Gear (settings) > Additional Settings > Loop video, it cannot be disabled.

In essence regardless of what the Loop setting is set to, videos will always loop now.

I believe this is triggered by enabling loop at least once.
After that it cannot be disabled although the toggle is in the off position.

Thanks for your support.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@TheShadowRunner TheShadowRunner added the Bug report Something isn't working label Feb 7, 2024
@TheShadowRunner TheShadowRunner changed the title bug: 19.04.37 YouTube loop patch always active, can't disable bug: 19.04.37 YouTube Auto-repeat / Loop patch always active, can't disable Feb 7, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Does the issue show up if you repatch and not include auto repeat patch?

Does patching an earlier version of YouTube also have the issue?

@oSumAtrIX
Copy link
Member

I can not reproduce the behavior. Check for this behavior on the unpatched app.

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Feb 7, 2024
@TheShadowRunner
Copy link
Author

TheShadowRunner commented Feb 7, 2024

Ok I repatched without "Always repeat" patch and the toggle "loop video" now seems to be working alright.

I guess I didn't understand the purpose of "Always repeat" as its description says "adds an option to always repeat videos when they end". To my understanding, this patch added the toggle "Loop video" feature.

It turns out this patch isn't needed for the "loop video" feature to be available and working.

It seems "Always repeat" patch does just what it's called, always repeat (and it doesn't respect the Loop video toggle here).

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Mar 21, 2024
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.187.0-dev.2](ReVanced/revanced-patches@v2.187.0-dev.1...v2.187.0-dev.2) (2023-07-26)

### Features

* **YouTube - Hide layout components:** Hide `chips shelf` ([ReVanced#2699](ReVanced/revanced-patches#2699)) ([8e6058b](ReVanced/revanced-patches@8e6058b))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.187.0](ReVanced/revanced-patches@v2.186.0...v2.187.0) (2023-08-02)

### Bug Fixes

* Remove version numbers from individual patches ([ReVanced#2709](ReVanced/revanced-patches#2709)) ([7a828ea](ReVanced/revanced-patches@7a828ea))
* **Sync for Reddit - Change OAuth client id:** Disable piracy detection ([cd103dd](ReVanced/revanced-patches@cd103dd))
* Use clearer descriptions ([8dbb0e2](ReVanced/revanced-patches@8dbb0e2))
* **YouTube - Spoof app version:** Fix grammar in description ([ReVanced#2711](ReVanced/revanced-patches#2711)) ([dd249e6](ReVanced/revanced-patches@dd249e6))
* **YouTube - Spoof App Version:** Remove 17.30.35 target (version no longer works correctly) ([ReVanced#2703](ReVanced/revanced-patches#2703)) ([210108b](ReVanced/revanced-patches@210108b))
* **YouTube - Theme:** only set splash screen color if background colors are set ([f058db4](ReVanced/revanced-patches@f058db4))

### Features

* **Joey for Reddit:** Add `Change OAuth client id` patch ([1bac47d](ReVanced/revanced-patches@1bac47d))
* **Joey for Reddit:** Add `Disable ads` patch ([ad7e147](ReVanced/revanced-patches@ad7e147))
* **Reddit is Fun - Spoof client:** Spoof the user agent ([b9aaf61](ReVanced/revanced-patches@b9aaf61))
* **Sync for Reddit:** add `Disable Sync for Lemmy bottom sheet` patch ([56b535b](ReVanced/revanced-patches@56b535b))
* **YouTube - Hide layout components:** Hide `chips shelf` ([ReVanced#2699](ReVanced/revanced-patches#2699)) ([8e6058b](ReVanced/revanced-patches@8e6058b))
* **YouTube:** add `Player Flyout Menu` patch ([ReVanced#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@aea0af0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants