Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YouTube - "People also watched" recommendations appearing despite hide option being enabled. #2703

Closed
3 tasks done
ikubaysan opened this issue Feb 8, 2024 · 11 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@ikubaysan
Copy link

ikubaysan commented Feb 8, 2024

Bug description

I have enabled the "Hide 'People also watched' recommendations" option, but I am still seeing them.

ReVanced Manager 1.18.0, patches applied today (February 7, 2024)
YouTube v19.04.37, installed today.
Android 10
ASUS Zenfone 7 Pro

303198016-e87f2559-6a46-4150-ba0a-e4dd075e3d8b

303198022-988722bb-1406-46c9-afca-3417216f1006

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ikubaysan ikubaysan added the Bug report Something isn't working label Feb 8, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 8, 2024

The hide recommendations filter uses the protobuffer, and this likely is the same issue as #2694

@LisoUseInAIKyrios LisoUseInAIKyrios added the Waiting on author Further information is requested label Feb 8, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 8, 2024

@ikubaysan the dev release is now the regular release.

Try re-patching 19.04.37 using Manager, and report back if the issue seems to be fixed or if you still see the 'People also watched' recommendations.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
@oSumAtrIX oSumAtrIX reopened this Feb 9, 2024
@cyberboh
Copy link

cyberboh commented Feb 9, 2024

I have this issue too. While my previous was resolved, but i get this another issue. YT 19.04.37, patched with CLI
These logs captured from my device, hope they help
log.txt
log2.txt

@oSumAtrIX
Copy link
Member

The logs are too long, please send the relevant lines from log.txt

@cyberboh
Copy link

cyberboh commented Feb 9, 2024

The logs are too long, please send the relevant lines from log.txt

you mean this?:

search_video_with_context.eml|36577d75ee6beb21|CellType|video_with_context_slots.eml|89c5c98b9637622a|ContainerType|ContainerType|ContainerType|ContainerType|ContainerType|metadata.eml|15b183e48ad65581|

@LisoUseInAIKyrios
Copy link
Contributor

Need to turn on log protobuffer as well.

@cyberboh
Copy link

cyberboh commented Feb 9, 2024

Need to turn on log protobuffer as well.

This:

02-09 22:10:05.239 11663 11862 D revanced: LithoFilterPatch: Searching ID: null Path: shelf_header.eml|eed05856e0fd4de9|CellType|modern_type_shelf_header_content.eml|42c34085eba66e4d|ContainerType|ContainerType|ContainerType|ContainerType| BufferStrings: People also watched❙sans-serif❙People also watched❙yt_outline_people_group_vd_theme_24❙eml.shelf_header❙

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 9, 2024

The recommended videos are hidden, but there is a new section above the hidden videos that still shows.

ppl watch

The filter:
^shelf_header.eml$yt_outline_people_group_vd_theme_24
Hides the 'people also watched' section (but not the 'show more' button)

A new section also shows up with the 'for you' results:
for you

@cyberboh
Copy link

cyberboh commented Feb 9, 2024

I also get the "For you" section.
And this "Popular today" suddenly appear. At the first time I took a logs it's hidden. Dunno if Google choose my account as a/b tester.

Screenshot_20240209_225057

@ILoveOpenSourceApplications

I actually had mentioned most of these categories in my #6 issue, the only one which I didn't come across is Popular today. I did want to report that the issue wasn't fixed then but didn't find myself the time to provide a feedback.

@oSumAtrIX oSumAtrIX added the Prioritized Prioritization over other issues label Feb 21, 2024
@oSumAtrIX
Copy link
Member

Looks to be A/B as I can not see this when I search for dog. I'll need someone to give me access to an affected account. Please contact me at osumatrix@revanced.app

tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.187.0-dev.3](ReVanced/revanced-patches@v2.187.0-dev.2...v2.187.0-dev.3) (2023-07-26)

### Bug Fixes

* **YouTube - Spoof App Version:** Remove 17.30.35 target (version no longer works correctly) ([ReVanced#2703](ReVanced/revanced-patches#2703)) ([210108b](ReVanced/revanced-patches@210108b))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
# [2.187.0](ReVanced/revanced-patches@v2.186.0...v2.187.0) (2023-08-02)

### Bug Fixes

* Remove version numbers from individual patches ([ReVanced#2709](ReVanced/revanced-patches#2709)) ([7a828ea](ReVanced/revanced-patches@7a828ea))
* **Sync for Reddit - Change OAuth client id:** Disable piracy detection ([cd103dd](ReVanced/revanced-patches@cd103dd))
* Use clearer descriptions ([8dbb0e2](ReVanced/revanced-patches@8dbb0e2))
* **YouTube - Spoof app version:** Fix grammar in description ([ReVanced#2711](ReVanced/revanced-patches#2711)) ([dd249e6](ReVanced/revanced-patches@dd249e6))
* **YouTube - Spoof App Version:** Remove 17.30.35 target (version no longer works correctly) ([ReVanced#2703](ReVanced/revanced-patches#2703)) ([210108b](ReVanced/revanced-patches@210108b))
* **YouTube - Theme:** only set splash screen color if background colors are set ([f058db4](ReVanced/revanced-patches@f058db4))

### Features

* **Joey for Reddit:** Add `Change OAuth client id` patch ([1bac47d](ReVanced/revanced-patches@1bac47d))
* **Joey for Reddit:** Add `Disable ads` patch ([ad7e147](ReVanced/revanced-patches@ad7e147))
* **Reddit is Fun - Spoof client:** Spoof the user agent ([b9aaf61](ReVanced/revanced-patches@b9aaf61))
* **Sync for Reddit:** add `Disable Sync for Lemmy bottom sheet` patch ([56b535b](ReVanced/revanced-patches@56b535b))
* **YouTube - Hide layout components:** Hide `chips shelf` ([ReVanced#2699](ReVanced/revanced-patches#2699)) ([8e6058b](ReVanced/revanced-patches@8e6058b))
* **YouTube:** add `Player Flyout Menu` patch ([ReVanced#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@aea0af0))
@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios removed Waiting on author Further information is requested Prioritized Prioritization over other issues labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants