generated from ReVanced/revanced-patches-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Mi Fitness - Fix login): Patch correct register #2942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t work. it reads reg 7 instead of 2.
src/main/kotlin/app/revanced/patches/mifitness/misc/login/FixLoginPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
changed the title
feat(Mi Fitness): fix for wrong register replacement
feat(Mi Fitness): Fix patch by patching correct register
Mar 30, 2024
oSumAtrIX
changed the title
feat(Mi Fitness): Fix patch by patching correct register
fix(Mi Fitness - Fix login): Fix by patching correct register
Mar 30, 2024
oSumAtrIX
changed the title
fix(Mi Fitness - Fix login): Fix by patching correct register
fix(Mi Fitness - Fix login): Patch correct register
Mar 30, 2024
revanced-bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
## [4.5.1-dev.2](v4.5.1-dev.1...v4.5.1-dev.2) (2024-03-30) ### Bug Fixes * **Mi Fitness - Fix login:** Patch correct register ([#2942](#2942)) ([dc96942](dc96942))
revanced-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
# [4.6.0](v4.5.0...v4.6.0) (2024-04-02) ### Bug Fixes * **Mi Fitness - Fix login:** Patch correct register ([#2942](#2942)) ([dc96942](dc96942)) * **Tumblr:** Restore compatibility with latest versions ([#2955](#2955)) ([2954ba7](2954ba7)) ### Features * **Tumblr:** Add `Fix old versions` patch ([#2954](#2954)) ([2fde60e](2fde60e))
E85Addict
pushed a commit
to E85Addict/revanced-patches
that referenced
this pull request
Apr 2, 2024
# [4.6.0](v4.5.0...v4.6.0) (2024-04-02) ### Bug Fixes * **Mi Fitness - Fix login:** Patch correct register ([ReVanced#2942](https://github.com/E85Addict/revanced-patches/issues/2942)) ([dc96942](dc96942)) * **Tumblr:** Restore compatibility with latest versions ([ReVanced#2955](https://github.com/E85Addict/revanced-patches/issues/2955)) ([2954ba7](2954ba7)) ### Features * **Tumblr:** Add `Fix old versions` patch ([ReVanced#2954](https://github.com/E85Addict/revanced-patches/issues/2954)) ([2fde60e](2fde60e)) ### Performance Improvements * Personal Logo && Add upstream sync ([755a32e](755a32e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that approach with reading register of the param does not work.
It was supposed to read
if-nez p2, :cond_0
and get 2 from that.Then to add instruction
const/4 p2, 0x0
, but instead it placedconst/4 p7, 0x0
In this method there is no p7 nor v7.
For now i will switch to hardcoding as it seems more change-resistant.