-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spotify): Add Unlock Spotify Premium
patch
#3044
Conversation
4cbf2b3
to
7fbb9c0
Compare
Is this different from what xManager can already do for Spotify? If it's the same, then it doesn't bring anything new but does bring patch upkeep and questions about unlocking. |
xManager is closed source and also muddies the patched apps; ReVanced, on the other hand, is open source and providers transparency, apart from that feature wise they should not differ. |
I'm still unsure about unlock patches, even if someone else is already doing the same. |
The contribution guidelines outline that patches that provide significant value are treated on a case-by-case basis, but I am also not entirely sure if we want a patch for an app that is known for aggressively fighting things like that. Users can technically use the standalone |
I like this option. Patching would be thru user provided patch option settings. That removes all needs of maintaining and supporting it here. So basically this PR would be closed without merging, and then users on Reddit or wherever can figure it out on their own. |
xManager has existed for a decent amount of time and they directly distribute the modded versions over the internet, by now I assume they'd have been DMCA'd if Spotify cared, what's the worst-case scenario? we have to take down the patch? |
I think it's fine to not merge this PR. At least it can act as a PoC and others can take an example from it. There are people that pick up dropped patches and eventually when ReVanced Manager allows, those can be used side by side with other patches such as ours. xManager technically bypasses DMCAs since it merely downloads the modded apps, unlike us. |
If i want to suggest something, I'd like to change patch from |
About
This PR adds a patch for Spotify to enable Spotify Premium by patching a native binary using a raw resource patch.
The question would be whether this patch should be merged, given that it's a patch to unlock Spotify Premium.