fix(YouTube - Spoof client): Clarify that only enter/exit fullscreen gesture does not work with Android VR spoof

[SodaWithoutSparkles]

Using a more conservative description of "may not work". From a sample size of 2, all other gestures did work.

Clarify that ReVanced gestures (brightness/volume) works and enter/exit mini-player works. Just that the enter/exit fullscreen by swiping the middle of the screen does not work.

Re: #3208 , ReVanced/revanced-integrations#644

[welcome]

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

[cyberboh]

I get this error while patching with 4.8.3-dev.2

Exception in thread "main" java.lang.NoSuchMethodError: 'void com.android.tools.smali.dexlib2.immutable.reference.ImmutableMethodReference.<init>(java.lang.String, java.lang.String, java.util.List, java.lang.String)'
        at app.revanced.patches.songpal.badge.fingerprints.ShowNotificationFingerprint.<clinit>(ShowNotificationFingerprint.kt:31)
        at app.revanced.patches.songpal.badge.RemoveNotificationBadgePatch.<init>(RemoveNotificationBadgePatch.kt:17)
        at app.revanced.patches.songpal.badge.RemoveNotificationBadgePatch.<clinit>(RemoveNotificationBadgePatch.kt)
        at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
        at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
        at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized(MethodHandleAccessorFactory.java:300)
        at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newFieldAccessor(MethodHandleAccessorFactory.java:140)
        at java.base/jdk.internal.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:145)
        at java.base/java.lang.reflect.Field.acquireFieldAccessor(Field.java:1185)
        at java.base/java.lang.reflect.Field.getFieldAccessor(Field.java:1164)
        at java.base/java.lang.reflect.Field.get(Field.java:442)
        at app.revanced.patcher.PatchBundleLoader$Utils.getInstance$revanced_patcher(PatchBundleLoader.kt:72)
        at app.revanced.patcher.PatchBundleLoader$3.invoke(PatchBundleLoader.kt:51)
        at app.revanced.patcher.PatchBundleLoader$3.invoke(PatchBundleLoader.kt:50)
        at kotlin.sequences.TransformingSequence$iterator$1.next(Sequences.kt:210)
        at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:170)
        at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Sequences.kt:194)
        at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:169)
        at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Sequences.kt:194)
        at kotlin.collections.CollectionsKt__MutableCollectionsKt.addAll(MutableCollections.kt:129)
        at app.revanced.patcher.PatchBundleLoader.<init>(PatchBundleLoader.kt:55)
        at app.revanced.patcher.PatchBundleLoader.<init>(PatchBundleLoader.kt)
        at app.revanced.patcher.PatchBundleLoader.<init>(PatchBundleLoader.kt:34)
        at app.revanced.patcher.PatchBundleLoader$Jar.<init>(PatchBundleLoader.kt:102)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:259)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

Seems error in xml or something :/

[LisoUseInAIKyrios]

It's something with the smali library bump from 3.0.5 to 3.0.7

dd1a087#r142432572

While Patcher is still at 3.0.5
https://github.com/ReVanced/revanced-patcher/blob/7be131d348ba70689369e4ecf82478c89d03e2a3/gradle/libs.versions.toml#L7

I think bumping the patcher dependency to 3.0.7 will fix this.

[oSumAtrIX]

That indicates a breaking change on smali even though patch was bumped. This should probably be reported.

[LisoUseInAIKyrios]

Should Patcher be bumped to 3.0.7, or should Patches revert back to 3.0.5?

Bumping patcher means Manager would need an update, so it's probably easier to revert patches to 3.0.5

[oSumAtrIX]

We can revert but eventually we need to update

[oSumAtrIX]

google/smali@bad9474#diff-1b64ab2237880ceb837437aa949dca5004f305bd0aac42fe8f6a67b3d6e971d6R60 here is the breaking change.

Tracking: google/smali#58