Support history v3 #3647
Merged
Support history v3 #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // <Router> and attaches another history listener. | ||
| if (unlisten) { | ||
| unlisten() | ||
| } |
I think it would be better to add back the invariant than let the engine handle it. It will probably not be super-helpful to people unless they're familiar with the API change between v2 and v3, in which case they probably aren't going to run into the issue anyways. |
|
Sure. Added back the invariant. |
|
👍 |
|
Is that an LGTM? I think we should cut this as an |
|
Yep, go nuts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code isn't going to win any beauty awards. I'd like to clean this up structurally before v3.0.0 final if I have time, but it's not going to involve any major API changes (just internal refactoring).
I figure it's okay to take out the invariant on
history.getCurrentLocationbecause anybody attempting to use a v2 history will just hit an exception whenhistory.getCurrentLocationfails due to not existing. If it comes up, it'd be easy enough to add back the inverse of the removed invariant to assert a non-v3 history.