Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Added a Molpro negative frequency test to Arkane #1599

Merged
merged 1 commit into from May 17, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented May 13, 2019

Bumping up RMG-Py's coverage by 0.01%!

@alongd alongd requested a review from mjohnson541 May 13, 2019 15:04
@alongd alongd self-assigned this May 13, 2019
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #1599 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   41.65%   41.67%   +0.01%     
==========================================
  Files         176      176              
  Lines       29102    29102              
  Branches     5988     5988              
==========================================
+ Hits        12122    12127       +5     
+ Misses      16142    16138       -4     
+ Partials      838      837       -1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 52.97% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19837cd...fe21b95. Read the comment docs.

@alongd
Copy link
Member Author

alongd commented May 16, 2019

@mjohnson541, this is a minor PR (just added a test). Could you take a look?

mjohnson541
mjohnson541 previously approved these changes May 17, 2019
Copy link
Contributor

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase?

@alongd
Copy link
Member Author

alongd commented May 17, 2019

Sure!

@mjohnson541 mjohnson541 merged commit c6f8f24 into master May 17, 2019
@mjohnson541 mjohnson541 deleted the molpro_neg_freq_tst branch May 17, 2019 21:00
@mliu49 mliu49 mentioned this pull request May 23, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants