Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added library list that support ReactiveCocoa #1743

Closed
wants to merge 3 commits into from

Conversation

Legoless
Copy link

A couple of libraries already support ReactiveCocoa and for others there are a couple of extensions available. This pull request adds a list of libraries that I could find open source online.

@jspahrsummers
Copy link
Member

As discussed in #1113, we'd only be interested in listing or “endorsing” libraries for which we've vetted the code quality. That's not to say that anything in this list wouldn't meet that standard, but without @ReactiveCocoa/reactivecocoa collaborators spending the time to investigate, it's hard to say.

@kastiglione You expressed interest in helping out with this sort of thing, but that was almost a year ago now. Would you still be up for it?

@Legoless
Copy link
Author

Understood, I can have a look as well. For starters, we could filter out those that are missing the Pods and that were not updated in last year or so. For standards, is there any document I could refer to?

@jspahrsummers
Copy link
Member

Sorry, no. It's not just code style that we're interested in, but higher-level architectural patterns and “soundness,” which is why I would really like ReactiveCocoa collaborators to be involved.

@Legoless
Copy link
Author

Okay, cool. Let me know if there is anything I can do.

@kastiglione
Copy link
Member

I'll try to take a look. What are the thoughts of coverage completeness, for those libraries that are strictly wrappers? Do we care if they don't cover the full API, or do we only care that the parts that are covered, are covered fairly idiomatically?

@jspahrsummers
Copy link
Member

Do we care if they don't cover the full API, or do we only care that the parts that are covered, are covered fairly idiomatically?

I don't mind not wrapping the full API. It should absolutely be idiomatic, though.

- [AFNetworking](https://github.com/AFNetworking/AFNetworking)
- [AFNetworking-RACExtensions](https://github.com/CodaFi/AFNetworking-RACExtensions)
- [AFNetworking-RACRetryExtensions](https://github.com/Legoless/AFNetworking-RACRetryExtensions)
- [DANReactiveLocationManager](https://github.com/wearebase/DANReactiveLocationManager)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖️ Non-idiomatic.

@Legoless
Copy link
Author

So should we update this and remove libraries? But if you are going to keep very strict rules about this, is almost pointless to have any list at all. I would suggest rather to put disclaimer or warnings near wrappers and only remove critical or really low quality ones.

@robb
Copy link
Member

robb commented Feb 25, 2015

👎 on the list, seems like the time could be better spent elsewhere and would incentivize people to get their name on the list for fake internet points.

@ashfurrow
Copy link
Member

All internet points are fake, @robb :P

@Legoless
Copy link
Author

I agree with @ashfurrow this is by no way meant to improve anyone's reputation. I did not even include any names. I just thought it was a nice addition to have this somewhere, it would definitely help me and probably some other developers as well. I understand all your points, so feel free to reject this, I just didn't think it would hurt anyone if this was in the main repo. :)

@ashfurrow
Copy link
Member

I think having a list of example uses of ReactiveCocoa would be a great help to beginners. I know the (few) that were available when I was learning were very helpful.

@kastiglione
Copy link
Member

very strict rules about this, is almost pointless to have any list at all.

@Legoless Other than for "completeness" what value is there in listing libraries that we have to warn against?

@kastiglione
Copy link
Member

I'm with @ashfurrow. If we can have resources to learn from, that's good. If "fake points" encourage "real" quality, that's fucking great trade off! 😄

@ashfurrow
Copy link
Member

@kastiglione I wish I could favourite GH comments.

@kastiglione
Copy link
Member

Me too. Where can we find a GitHubber with pull around here. 🌟

@robrix
Copy link
Contributor

robrix commented Feb 25, 2015

👎 to playing favourites with comments. All of your comments are equally beautiful ❤️

@Legoless
Copy link
Author

@kastiglione Well, on the other side, if for nothing else, at least us beginners could learn how not to do things. ;)

@RuiAAPeres
Copy link
Member

I think it would be useful and educational to layout some tips/patterns/recommendations when creating a wrapper.

@RuiAAPeres RuiAAPeres closed this Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants