Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observer.OnCompleted should be optional #2

Closed
jochasinga opened this issue Nov 1, 2016 · 0 comments
Closed

observer.OnCompleted should be optional #2

jochasinga opened this issue Nov 1, 2016 · 0 comments
Labels
validated bug Bug validated by the RxGo team.

Comments

@jochasinga
Copy link
Member

Right now it will panic

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference

Whenever an OnCompleted handler isn't defined in an Observer. (Try to comment this out to see what I mean).
@jochasinga jochasinga added the validated bug Bug validated by the RxGo team. label Nov 1, 2016
@JensRantil JensRantil mentioned this issue Feb 7, 2017
Closed
@guider guider mentioned this issue Dec 3, 2018
Closed
teivah pushed a commit that referenced this issue Mar 11, 2019
@MarekLabuz
Merge pull request #2 from ReactiveX/v2
21c5135 
V2
jmc-netactuate added a commit to jmc-netactuate/RxGo that referenced this issue May 24, 2019
@jmc-netactuate
Merge infinite loop ReactiveX#2
aae0796 
Move wg.Done() into a defer instead of placing it after a break where it will never be hit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
validated bug Bug validated by the RxGo team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jochasinga