Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename flatMap to mergeMap #333

Closed
benlesh opened this issue Sep 17, 2015 · 2 comments · Fixed by #344
Closed

Rename flatMap to mergeMap #333

benlesh opened this issue Sep 17, 2015 · 2 comments · Fixed by #344
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Sep 17, 2015

Again, the result of bike shedding elsewhere. cc/ @jhusain

However with this one, since flatMap is so popular and known from other languages/libraries, we might want to leave an alias.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Sep 17, 2015
@tetsuharuohzeki
Copy link
Contributor

I think we should leave flatMap() as an alias if we do this change. flatMap is very popular terminology as to flattening mapping name so it's not better to remove flatMap name for interoperability of concept of this area.

@jhusain
Copy link

jhusain commented Sep 18, 2015

No problem leaving this alias.

JH

On Sep 17, 2015, at 7:34 PM, Tetsuharu OHZEKI notifications@github.com wrote:

I think we should leave flatMap() as an alias if we do this change. flatMap is very popular terminology as to flattening mapping name so it's not better to remove flatMap name for interoperability of concept of this area.

—
Reply to this email directly or view it on GitHub.

@kwonoj kwonoj mentioned this issue Sep 18, 2015
Merged
ghost pushed a commit to facebookarchive/nuclide that referenced this issue May 18, 2016
Add mergeMap (alias for flatMap) to RxJS type defs
f5b625d 
Summary:
`flatMap` was [renamed to `mergeMap`][1], and `flatMap` was kept as an
alias because of its widespread use. Add identical [`mergeMap`][2] type
def.

[1]: ReactiveX/rxjs#333
[2]: http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#instance-method-mergeMap

Reviewed By: hansonw

Differential Revision: D3317186

fbshipit-source-id: 24cd4b8fe057473b31ff39ee940c42a423c02125
@jayphelps jayphelps mentioned this issue Oct 26, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(mergeMap): rename flatMap to mergeMap kwonoj/rxjs
3 participants
@tetsuharuohzeki @jhusain @benlesh