Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in all major browsers and engines #998

Closed
benlesh opened this issue Dec 8, 2015 · 8 comments
Closed

Run tests in all major browsers and engines #998

benlesh opened this issue Dec 8, 2015 · 8 comments
Labels
help wanted Issues we wouldn't mind assistance with.
Milestone
5.0.0-beta.2

Comments

@benlesh
Copy link
Member

benlesh commented Dec 8, 2015

This needs to be run against:

  • IE 9+,
  • Chrome
  • FF
  • Safari
  • Android
  • iOS
  • Node > 0.12

in an automated way. Currently we're only running against Node, and that's not good.
@benlesh benlesh added help wanted Issues we wouldn't mind assistance with. priority: critical labels Dec 8, 2015
@luisgabriel
Copy link
Contributor

The idea here is to use a CI like saucelabs?

@kwonoj
Copy link
Member

kwonoj commented Dec 8, 2015

Yes it is. I was trying this for some time but wanted to land #826 this before, so hold for a while. Requires two steps I assume,

  • setup test environment using runner like karma can do browser test with existing spec
  • setup travis pipeline to saucelab to run node test on travis as ci process, rest of browser test being pipelined to saucelabs.

@kwonoj
Copy link
Member

kwonoj commented Dec 8, 2015

I'll try to spend couple of days to see if I can make land karma into current codebase quickly. That can be starting point.

@kwonoj
Copy link
Member

kwonoj commented Dec 9, 2015

Seems #733 is related.

kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 9, 2015
@kwonoj
chore(test): setup karma test runner against chrome browser
dfed4d9 
- initial bootstrap config for karma runner against chrome
- ci server is not configured yet

relates to ReactiveX#998
@kwonoj kwonoj mentioned this issue Dec 9, 2015
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 9, 2015
@kwonoj
chore(test): setup karma test runner against chrome browser
8c3746f 
- initial bootstrap config for karma runner against chrome
- ci server is not configured yet

relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 9, 2015
@kwonoj
chore(test): setup karma test runner against chrome browser
23bbe89 
- initial bootstrap config for karma runner against chrome
- ci server is not configured yet

relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 10, 2015
@kwonoj
chore(test): setup karma test runner against chrome browser
d69b175 
- initial bootstrap config for karma runner against chrome
- ci server is not configured yet

relates to ReactiveX#998
kwonoj added a commit that referenced this issue Dec 10, 2015
@kwonoj
chore(test): setup karma test runner against chrome browser
9996d77 
- initial bootstrap config for karma runner against chrome
- ci server is not configured yet

relates to #998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 10, 2015
@kwonoj
chore(travis): update travis script, add trigger saucelabs karma test
3c104b6 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 10, 2015
@kwonoj
chore(travis): update travis script, add trigger saucelabs karma test
c297714 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 10, 2015
@kwonoj
chore(travis): update travis script, add trigger saucelabs karma test
94f42ee 
relates to ReactiveX#998
@benlesh benlesh mentioned this issue Dec 14, 2015
Closed
kwonoj added a commit that referenced this issue Jan 4, 2016
@kwonoj
chore(travis): update travis script, add trigger saucelabs karma test
70b1997 
relates to #998
@kwonoj kwonoj mentioned this issue Jan 4, 2016
Closed
@kwonoj
Copy link
Member

kwonoj commented Jan 4, 2016

As referenced in PR #1023 , it's required to create official RxJS saucelabs account (https://saucelabs.com/) and configure travis environment values. By saucelabs account requires email account when creating account and it should not be my personal one, asking @Blesh to create one.

This was referenced Jan 5, 2016
Closed
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test-helper): setup promise polyfill for browser testing
23706f0 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test-helper): setup promise polyfill for browser testing
1d7b568 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test-helper): setup promise polyfill for browser testing
21f4808 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test-helper): setup promise polyfill for browser testing
447143d 
relates to ReactiveX#998
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test-helper): setup promise polyfill for browser testing
43ddf93 
relates to ReactiveX#998
@kwonoj kwonoj mentioned this issue Jan 8, 2016
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test): update dependency references in tests
d92b81c 
relates to ReactiveX#998
@kwonoj kwonoj mentioned this issue Jan 8, 2016
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 8, 2016
@kwonoj
chore(test): update dependency references in tests
05ac8dd 
relates to ReactiveX#998
This was referenced Jan 8, 2016
Merged
Closed
@kwonoj
Copy link
Member

kwonoj commented Jan 13, 2016

For some reason I thought email address was permanent login credential which is not actually and can be changed easily. I'm creating account by my own, change those information accordingly later to close out this issue.

kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 13, 2016
@kwonoj
docs(README): add browser test covergae matrix
776f23f 
relates to ReactiveX#998
@kwonoj kwonoj mentioned this issue Jan 13, 2016
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 13, 2016
@kwonoj
docs(README): add browser test coverage matrix
b6b3245 
relates to ReactiveX#998
@benlesh benlesh added this to the 5.0.0-beta.2 milestone Jan 15, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Jan 16, 2016
@kwonoj
chore(test): expand browser test coverage
3eba7b2 
- expand browser list to be tested
- update karma configuration for newly added rx.dom test cases

closes ReactiveX#998
@kwonoj kwonoj mentioned this issue Jan 16, 2016
Closed
@kwonoj
Copy link
Member

kwonoj commented Jan 16, 2016

#1187 is decoration change, so will close this issue by #1199 which now expands browser matrix. Each test failures will be tracked separately instead of using this broad issue.

@kwonoj kwonoj closed this as completed in ebfa7d2 Jan 16, 2016
benlesh pushed a commit that referenced this issue Feb 2, 2016
@kwonoj @benlesh
docs(README): add browser test coverage matrix
27a19cc 
relates to #998
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
5.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

chore(test): expand browser test coverage kwonoj/rxjs
3 participants
@luisgabriel @kwonoj @benlesh