chore(package.json): rename docgen to publish_docs, add build_docs #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,8 @@ | |||
| "build_perf": "npm run build_cjs && npm run build_global && webdriver-manager update && npm run perf", | |||
| "build_test": "rm -rf dist/ && npm run lint && npm run build_cjs && jasmine", | |||
| "build_cover": "rm -rf dist/ && npm run lint && npm run build_cjs && npm run cover", | |||
| "build_docs": "./docgen.sh", | |||
| "build_docs": "npm run build_es6 && npm run tests2png && esdoc -c esdoc.json", | |||
| "publish_docs": "./publish_docs.sh", | |||
There was a problem hiding this comment.
just minor (and picky) suggestion - what about replace inner invocation in shell script to run build_docs? then if change's required, only one place can be updated.
…ript Renamed npm script build_docs => publish_docs, because that's what it actually does, and renamed docgen.sh to publish_docs.sh. Then, made npm script build_docs that simply builds the docs webpage, without publishing.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed npm script build_docs => publish_docs, because that's what it actually does, and renamed
docgen.sh to publish_docs.sh. Then, made npm script build_docs that simply builds the docs webpage,
without publishing.
Just a minor PR to clean up before I start major work related to docs.