Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forkJoin): accepts observables emitting null or undefined #1368

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 19, 2016

closes #1362.

This PR updates behavior of forkJoin to check provided observable has emitted value by introducing explicit flag as same as RxJS 4 implementation to avoid emitting null or undefined considered as observable does not contain any value.

@@ -13,6 +13,18 @@ describe('Observable.forkJoin', function () {
var expected = '--------------(x|)';

expectObservable(e1).toBe(expected, {x: ['d', 'b', '3']});

//Hack - just adding one new test cases in here or either jasmin-is-weird-spec.js,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another weirdness of jasmine behavior, just separate this as test case makes another test fails. Placing under 'jasmine-is-weird' also doesn't work in this case.

@kwonoj
Copy link
Member Author

kwonoj commented Feb 24, 2016

I'll check this in around today, leaving bit more to see any other suggestions around.

@kwonoj
Copy link
Member Author

kwonoj commented Feb 25, 2016

Merged with 6279d6b.

@kwonoj kwonoj closed this Feb 25, 2016
@kwonoj kwonoj deleted the fix-forkjoin branch February 25, 2016 06:28
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForkJoin not emit next if some of result is null
1 participant