fix(takeLast): fix takeLast behavior to emit correct order #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nice! Thanks for the fix |
| expect(expected.length).toBe(0); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Can we change the above tests to use marble diagrams and virtual scheduling?
There was a problem hiding this comment.
I think so, let me do that.
There was a problem hiding this comment.
I don't mind keeping one synchronous test, of course, but the marble tests are more analogous to the issue that was reported (which was using an interval).
|
Updated PR to use marble diagram for test cases. |
| it('should take last three values', () => { | ||
| const e1 = cold('--a-----b----c---d--| '); | ||
| const e1subs = '^ ! '; | ||
| const expected = '--------------------(bcd|)'; |
|
Merged with 73eb658. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1407
This PR tries to fix behavior of
takeLastby changing ring buffer indexing routines. Maybe I miss something, but so far it looks work correctly./cc @staltz for visibility.