Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal : type definition test cases #1414

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Mar 2, 2016

Now test cases are migrated in typescript, it is possible to integrate type definition test into existing test case execution environment. This PR is initial proposal of logistics.

Changes are straightforward, test helper exports interface type for type definition assertion actually doesn't do anything but only serves as container of all type definition test. These will be verified via compile time of test cases.

In test cases, very bottom of each test contains type assertion and list out possible type definition test cases, majorly

  • operator input signature accepts parameter as expected
  • operator chain, or subscription correctly delivers context of value type <T>
  • etcs

intentionwise this is same as #1189 does, only difference is logistics.

/cc @david-driscoll for visibility also.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 8, 2016

Rebased.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 9, 2016

@david-driscoll , would you able to share opinion this would works for you for type definition test?

@david-driscoll
Copy link
Member

👍 Looks great, I need to get rid of that other PR and redo it some night.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 9, 2016

Cool, I'll check this in around today and it'll unblock your PR #1189.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 10, 2016

Merged with fffc586.

@kwonoj kwonoj closed this Mar 10, 2016
@kwonoj kwonoj deleted the test-type branch March 10, 2016 06:21
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants