Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Observable.prototype.forEach): removed thisArg to match es-observable spec #1415

Closed
wants to merge 1 commit into from
Closed

Conversation

tetsuharuohzeki
Copy link
Contributor

BREAKING CHANGE: thisArg removed to match es-observable spec

@benlesh
Copy link
Member

benlesh commented Mar 2, 2016

LGTM. I hate thisArgs haha.

@benlesh benlesh added PR: lgtm and removed PR: lgtm labels Mar 2, 2016
@benlesh
Copy link
Member

benlesh commented Mar 2, 2016

Actually, @saneyuki... the commit message needs improvement:

fix(Observable.prototype.forEach): removed thisArg to match es-observable spec

BREAKING CHANGE: thisArg removed to match es-observable spec

@benlesh
Copy link
Member

benlesh commented Mar 2, 2016

... that way it will show up nicely in our CHANGLOG.md

…able spec

BREAKING CHANGE: thisArg removed to match es-observable spec
@tetsuharuohzeki
Copy link
Contributor Author

Actually, @saneyuki... the commit message needs improvement:

oops! I forgot it!

@tetsuharuohzeki tetsuharuohzeki changed the title fix(forEach): remove thisArg fix(Observable.prototype.forEach): removed thisArg to match es-observable spec Mar 3, 2016
@tetsuharuohzeki
Copy link
Contributor Author

@Blesh

updated :)

@kwonoj
Copy link
Member

kwonoj commented Mar 3, 2016

Merged with d5f1bcd, thanks @saneyuki

@kwonoj kwonoj closed this Mar 3, 2016
@tetsuharuohzeki tetsuharuohzeki deleted the foreach-this branch March 3, 2016 07:51
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants