retry: fixes and tests

[staltz]

Resolves (half of) #546.

[kwonoj]

What happens if resubscription occurs sufficiently large, i.e) invoked with retry() without param to allow indefinite retry and source fails more than several thousands (>10000 maybe) ?

[kwonoj]

Though I think that's sort of extreme cases usually do not expect to happen in real.

[staltz]

What happens if resubscription occurs sufficiently large, i.e) invoked with retry() without param to allow indefinite retry and source fails more than several thousands (>10000 maybe) ?

In marble tests there is a time limit, maxFrames = 750. However, if the source is cold('#'), then the retries will happen synchronously and the time frame will not progress at all in the TestScheduler, so it's possible to put the test in an infinite loop until the test runner breaks.

[kwonoj]

Actually question was about not creating test cases, trying with actual code such as Observable.throw().retry(LAAARGE) (pseudo, of course) not run by testscheduler. Just curiosity though.

[staltz]

With RxJS 4, Observable.throw().retry() (indefinite) throws the error:

"Maximum call stack size exceeded"

I'd expect RxJS Next to do the same.

[kwonoj]

Interesting, thanks for confirmation.

[staltz]

Actually, sorry, that was RxJS 2. With RxJS 4, the page freezes. Probably doing an infinite loop.

[kwonoj]

I just did quick try with RxJS4 + node myself and behavior was same, it seems does infinite retrying. I can give a try with this changes once it's merged. Again, thanks! :)

[benlesh]

@staltz ... this is precisely the solution I was thinking of when I first found this issue the other day. Nice work.

[benlesh]

Merged with 09b475a..

Also, I had to pin eslint to the original version we had installed, I had wiped out my node_modules directory and npm installed, and it installed eslint 1.7.0, which was giving false positives on our spec files. I just pinned it to a version I knew would work with our build.

[staltz]

Good!