Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromArray to report Element at index $i is null #6460

Closed
akarnokd opened this issue Apr 13, 2019 · 1 comment
Closed

fromArray to report Element at index $i is null #6460

akarnokd opened this issue Apr 13, 2019 · 1 comment
Labels
2.x Cleanup good first issue PR welcome
Milestone
2.2 backlog

Comments

@akarnokd
Copy link
Member

Currently, Observable.fromArray says The $i th element is null, which is a bit misleading as i is the element index. Update the error message to The element at index $i is null. The Flowable version should be updated if necessary. Note that the null checks appear multiple places.
@akarnokd akarnokd added this to the 2.2 backlog milestone Apr 13, 2019
iruizm added a commit to iruizm/RxJava that referenced this issue Apr 13, 2019
@iruizm
Change error message in ObservableFromArray
72cc01f 
Changed error message from "The $i th element is null" to "The element at index $i is null".

Solves ReactiveX#6460
@iruizm iruizm mentioned this issue Apr 13, 2019
Merged
iruizm added a commit to iruizm/RxJava that referenced this issue Apr 13, 2019
@iruizm
Change error messages in FlowableFromArray
fa8abac 
Changed error messages from "array element is null" to "The element at index $i is null".

Solves ReactiveX#6460
akarnokd pushed a commit that referenced this issue Apr 13, 2019
@iruizm @akarnokd
Change error message in ObservableFromArray (#6461)
deeb141 
* Change error message in ObservableFromArray

Changed error message from "The $i th element is null" to "The element at index $i is null".

Solves #6460

* Change error messages in FlowableFromArray

Changed error messages from "array element is null" to "The element at index $i is null".

Solves #6460
@akarnokd
Copy link
Member Author

Closing via #6461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Cleanup good first issue PR welcome
Projects
None yet
Milestone
2.2 backlog
Development

No branches or pull requests
1 participant
@akarnokd