-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change error message in ObservableFromArray #6461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed error message from "The $i th element is null" to "The element at index $i is null". Solves ReactiveX#6460
Could you please update these locations as well? |
Codecov Report
@@ Coverage Diff @@
## 2.x #6461 +/- ##
============================================
+ Coverage 98.26% 98.28% +0.01%
+ Complexity 6294 6292 -2
============================================
Files 675 675
Lines 45173 45173
Branches 6246 6246
============================================
+ Hits 44391 44400 +9
+ Misses 246 237 -9
Partials 536 536
Continue to review full report at Codecov.
|
Changed error messages from "array element is null" to "The element at index $i is null". Solves ReactiveX#6460
Sure, it's done. |
akarnokd
approved these changes
Apr 13, 2019
vanniktech
approved these changes
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the error message when an element at position i is null to what was suggested in #6460 .