Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message in ObservableFromArray #6461

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Conversation

iruizm
Copy link

@iruizm iruizm commented Apr 13, 2019

Changed the error message when an element at position i is null to what was suggested in #6460 .

Changed error message from "The $i th element is null" to "The element at index $i is null".

Solves ReactiveX#6460
@akarnokd akarnokd added this to the 2.2 backlog milestone Apr 13, 2019
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #6461 into 2.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6461      +/-   ##
============================================
+ Coverage     98.26%   98.28%   +0.01%     
+ Complexity     6294     6292       -2     
============================================
  Files           675      675              
  Lines         45173    45173              
  Branches       6246     6246              
============================================
+ Hits          44391    44400       +9     
+ Misses          246      237       -9     
  Partials        536      536
Impacted Files Coverage Δ Complexity Δ
...internal/operators/flowable/FlowableFromArray.java 94.91% <100%> (ø) 3 <0> (ø) ⬇️
...rnal/operators/observable/ObservableFromArray.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 87.58% <0%> (-8.5%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 91.79% <0%> (-2.99%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 95.21% <0%> (-1.07%) 3% <0%> (ø)
...activex/internal/schedulers/ExecutorScheduler.java 95.97% <0%> (-1.01%) 10% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04cfb8...fa8abac. Read the comment docs.

Changed error messages from "array element is null" to "The element at index $i is null".

Solves ReactiveX#6460
@iruizm
Copy link
Author

iruizm commented Apr 13, 2019

Sure, it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants