Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should filter() be converted from Func<T, Boolean> to Pred<T> #8

Closed
benjchristensen opened this issue Jan 16, 2013 · 4 comments
Closed
Labels
Milestone

Comments

@benjchristensen
Copy link
Member

Should we add a new special predicate object instead of using Func<T, Boolean>?

@benjchristensen
Copy link
Member Author

I am fine with Func<T, Boolean>.

The performance difference for autoboxing from Boolean to boolean should be trivial for this use case and I don't find the <T, Boolean> as enough clutter to warrant a different object.

But I'm not strongly opinionated either way.

@abersnaze
Copy link
Contributor

If Pred could extend Func<T, Boolean> but still have lower case boolean return type maybe we could add it later if we need to.

@benjchristensen
Copy link
Member Author

Screen Shot 2013-01-16 at 3 12 57 PM

@abersnaze
Copy link
Contributor

sad face

jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
Added ability do decorate Consumer<T>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants