Reimplement the 'SkipLast' operator #1050
Conversation
|
RxJava-pull-requests #966 FAILURE |
| /** | ||
| * Store the last count elements until now. | ||
| */ | ||
| private final Deque<T> deque = new LinkedList<T>(); |
There was a problem hiding this comment.
How about using a ringbuffer instead of the linkedlist while we are at it?
There was a problem hiding this comment.
Do you mean ArrayDeque? If so, I need to wrap the value with a Notification since ArrayDeque does not support null.
There was a problem hiding this comment.
Take a look at NotificationLite for efficient notification wrapping. Purely for internal use.
There was a problem hiding this comment.
LinkedList:
Iteration 1: 18478.082 ns/op
Iteration 2: 18549.588 ns/op
Iteration 3: 18496.627 ns/op
Iteration 4: 18594.022 ns/op
Iteration 5: 18491.945 ns/op
Iteration 1: 18498.661 ns/op
Iteration 2: 18415.850 ns/op
Iteration 3: 18464.311 ns/op
Iteration 4: 18459.684 ns/op
Iteration 5: 18499.839 ns/op
ArrayDeque+Notification:
Iteration 1: 18277.651 ns/op
Iteration 2: 17660.270 ns/op
Iteration 3: 17575.652 ns/op
Iteration 4: 18055.774 ns/op
Iteration 5: 17477.764 ns/op
Iteration 1: 17488.280 ns/op
Iteration 2: 17413.479 ns/op
Iteration 3: 17503.564 ns/op
Iteration 4: 17376.135 ns/op
Iteration 5: 17450.446 ns/op
Looks ArrayDeque+Notification is better than LinkedList.
There was a problem hiding this comment.
ArrayDeque+NotificationLite is impressive:
Iteration 1: 14854.581 ns/op
Iteration 2: 14842.878 ns/op
Iteration 3: 14940.360 ns/op
Iteration 4: 15131.214 ns/op
Iteration 5: 14767.790 ns/op
Iteration 1: 14604.962 ns/op
Iteration 2: 14606.918 ns/op
Iteration 3: 14624.361 ns/op
Iteration 4: 14739.717 ns/op
Iteration 5: 14541.750 ns/op
|
RxJava-pull-requests #967 SUCCESS |
|
Updated to ArrayDeque+NotificationLite. Thank you, @akarnokd and @benjchristensen |
|
RxJava-pull-requests #968 SUCCESS |
|
RxJava-pull-requests #969 SUCCESS |
Reimplement the 'SkipLast' operator
This PR did the following work:
SkipLastoperator to two different classes:OperatorSkipLastandOperatorSkipLastWithTimed.OperatorSkipLastWithTimedthat when all elements are valid,onCompletedwill not be called. The unit test istestSkipLastTimedWhenAllElementsAreValid.