Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperatorTakeUntil #1135

Merged
merged 2 commits into from
May 5, 2014
Merged

OperatorTakeUntil #1135

merged 2 commits into from
May 5, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Apr 30, 2014

Operator TakeUntil

Issue #1060

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #1047 SUCCESS
This pull request looks good

@akarnokd akarnokd mentioned this pull request Apr 30, 2014
Closed
57 tasks
@akarnokd
Copy link
Member

Generally looks okay, but the original logic could be improved a bit:

  • Instead of the inner Notification I would use a HALT token to indicate termination, so we don't create objects for every raw notification.
  • Final both inner Observable.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #1049 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #1054 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request May 5, 2014
@benjchristensen
Merge pull request #1135 from zsxwing/take-until
312cbf1 
OperatorTakeUntil
@benjchristensen benjchristensen merged commit 312cbf1 into ReactiveX:master May 5, 2014
@zsxwing zsxwing deleted the take-until branch May 6, 2014 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsxwing @cloudbees-pull-request-builder @akarnokd @benjchristensen