Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'contains' signature to 'contains(Object)' #1142

Merged
merged 1 commit into from
May 5, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented May 3, 2014

The original contains signature can not support the following codes:

    public void test() {
        ArrayList<String> l = new ArrayList<String>();
        l.add("test");
        Observable<ArrayList<String>> o = Observable.<ArrayList<String>>from(l);
        o.contains(Arrays.asList("test"));
    }

This PR changes the signature from contains(T) to contains(Object). It's also consistent with equals(Object).

This change should not break the old codes.

@cloudbees-pull-request-builder

RxJava-pull-requests #1055 FAILURE
Looks like there's a problem with this pull request

benjchristensen added a commit that referenced this pull request May 5, 2014
Update 'contains' signature to 'contains(Object)'
@benjchristensen benjchristensen merged commit 63576cc into ReactiveX:master May 5, 2014
@zsxwing zsxwing deleted the contains branch May 6, 2014 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants