Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rest operators to RxScala #1316

Merged
merged 21 commits into from
Jun 8, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Jun 4, 2014

This PR added the rest operators to RxScala. However, I think some operators in rxjava-math, rxjava-string , such as min, max, average, are worth to add to RxScala. What do you think? @headinthebox, @samuelgruetter

@cloudbees-pull-request-builder

RxJava-pull-requests #1212 SUCCESS
This pull request looks good

@headinthebox
Copy link
Contributor

If we put them in a different package as extension methods I'm fine. Then you can bring them into scope them as you wish.

@headinthebox
Copy link
Contributor

Thanks @samuelgruetter and @zsxwing
I'll review this in depth tomorrow (sorry) Friday morning.

@cloudbees-pull-request-builder

RxJava-pull-requests #1217 SUCCESS
This pull request looks good

@zsxwing
Copy link
Member Author

zsxwing commented Jun 5, 2014

I gave up the idea that converting Map[K, Seq[V]] to Map<K, Collection<V>>. It's much more complicated than I thought. Directly implementing toMultimap in RxScala looks much easier.

@zsxwing
Copy link
Member Author

zsxwing commented Jun 5, 2014

I will rewrite toMap in another PR as it's a breaking change.

@cloudbees-pull-request-builder

RxJava-pull-requests #1218 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #1222 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #1233 SUCCESS
This pull request looks good

@zsxwing
Copy link
Member Author

zsxwing commented Jun 8, 2014

But then I think RxScalaDemo should clearly explain that obs.subscribe(onNext), obs.foreach(onNext), and for (e <- obs) onNext(e)) are exactly the same.

Added subscribeExample for this. I added it at the beginning of RxScalaDemo so that people can easily notice it.

@cloudbees-pull-request-builder

RxJava-pull-requests #1244 SUCCESS
This pull request looks good

@zsxwing
Copy link
Member Author

zsxwing commented Jun 8, 2014

Overrode the last commit to fix the typos.

@cloudbees-pull-request-builder

RxJava-pull-requests #1251 SUCCESS
This pull request looks good

@samuelgruetter
Copy link
Contributor

LGTM. Thank you @zsxwing!

@headinthebox
Copy link
Contributor

Thanks @zsxwing .

@benjchristensen can you merge this, then I can make a pass over it so see if there is any fine tuning left.

benjchristensen added a commit that referenced this pull request Jun 8, 2014
Add the rest operators to RxScala
@benjchristensen benjchristensen merged commit 057db88 into ReactiveX:master Jun 8, 2014
@zsxwing zsxwing deleted the rxscala-more branch June 8, 2014 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants