Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toSingle() should use unsafeSubscribe #3055

Merged
merged 1 commit into from
Jul 14, 2015
Merged

toSingle() should use unsafeSubscribe #3055

merged 1 commit into from
Jul 14, 2015

Conversation

davidmoten
Copy link
Collaborator

As per my comment in #3049, Observable.toSingle should use unsafeSubscribe internally.

This PR includes a unit test that failed on previous code.

@davidmoten
Copy link
Collaborator Author

Unrelated test failure:

testMultiThreadedWithNPEinMiddle FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:92)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertTrue(Assert.java:54)
        at rx.internal.operators.OperatorSerializeTest.testMultiThreadedWithNPEinMiddle(OperatorSerializeTest.java:148)

benjchristensen added a commit that referenced this pull request Jul 14, 2015
@benjchristensen
Merge pull request #3055 from davidmoten/single-subscribe-fix
9269692 
toSingle() should use unsafeSubscribe
@benjchristensen benjchristensen merged commit 9269692 into ReactiveX:1.x Jul 14, 2015
@benjchristensen benjchristensen mentioned this pull request Jul 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmoten @benjchristensen