Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add Disposable Observer for Maybe, Completable & Single #4504

Merged
merged 1 commit into from
Sep 8, 2016
Merged

2.x: Add Disposable Observer for Maybe, Completable & Single #4504

merged 1 commit into from
Sep 8, 2016

Conversation

vanniktech
Copy link
Collaborator

@vanniktech vanniktech commented Sep 8, 2016

Also any reason the Dispoable is called s? Is it still from the Subscription time?

Fixes #4501

@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 8, 2016
@vanniktech
Copy link
Collaborator Author

Seems unrelated:

io.reactivex.internal.operators.observable.ObservableRefCountTest > testRepeat FAILED
    java.lang.AssertionError: Error(s) present: [java.lang.IllegalStateException: onSubscribe not called in proper order] (latch = 1, values = 51, errors = 1, completions = 0)
        at io.reactivex.observers.TestObserver.fail(TestObserver.java:363)
        at io.reactivex.observers.TestObserver.assertNoErrors(TestObserver.java:411)
        at io.reactivex.internal.operators.observable.ObservableRefCountTest.testRepeat(ObservableRefCountTest.java:195)

        Caused by:
        io.reactivex.exceptions.CompositeException
            at io.reactivex.observers.TestObserver.fail(TestObserver.java:364)
            ... 2 more

            Caused by:
            io.reactivex.exceptions.CompositeException$CompositeExceptionCausalChain: Chain of Causes for CompositeException In Order Received =>

                Caused by:
                java.lang.IllegalStateException: onSubscribe not called in proper order

@akarnokd
Copy link
Member

akarnokd commented Sep 8, 2016

Yep, I'll fix that next - started to become annoying to me too.

@akarnokd akarnokd merged commit d3feccb into ReactiveX:2.x Sep 8, 2016
@vanniktech vanniktech deleted the 2.x_reactive_disposable_observers branch September 8, 2016 09:21
@akarnokd akarnokd mentioned this pull request Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants