2.x: cleanup, fixes and coverage 10/25 #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.66% (diff: 92.12%)@@ 2.x #4766 diff @@
==========================================
Files 570 570
Lines 36784 36711 -73
Methods 0 0
Messages 0 0
Branches 5570 5555 -15
==========================================
+ Hits 35094 35120 +26
+ Misses 735 662 -73
+ Partials 955 929 -26
|
JakeWharton
approved these changes
Oct 25, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of my dedicated coverage improvement run.
skipUntillifecycle and concurrency properties.concatMapEagererror management.Flowable.scan(T, BiFunction)now emits the initial value only when the upstream signals an event. This has the effect that even if there is a downstream request, the initial value won't get emitted. This change reduces the overhead of the operator greatly.