Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: document (internal) SimpleQueue #5056

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 3, 2017

The interface was missing javadoc on its methods.

@akarnokd akarnokd added this to the 2.0 backlog milestone Feb 3, 2017
@codecov
Copy link

codecov bot commented Feb 3, 2017

Codecov Report

Merging #5056 into 2.x will increase coverage by 0.19%.

@@             Coverage Diff              @@
##                2.x    #5056      +/-   ##
============================================
+ Coverage     95.57%   95.76%   +0.19%     
- Complexity     5542     5548       +6     
============================================
  Files           612      612              
  Lines         39576    39576              
  Branches       5553     5553              
============================================
+ Hits          37824    37901      +77     
+ Misses          764      723      -41     
+ Partials        988      952      -36
Impacted Files Coverage Δ Complexity Δ
...al/operators/observable/ObservableSampleTimed.java 93.33% <ø> (-5%) 3% <ø> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <ø> (-4.62%) 27% <ø> (-1%)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 97.95% <ø> (-2.05%) 2% <ø> (ø)
...ternal/operators/flowable/FlowableSampleTimed.java 95.58% <ø> (-1.48%) 3% <ø> (ø)
...io/reactivex/subscribers/SerializedSubscriber.java 92.04% <ø> (-1.14%) 24% <ø> (-1%)
...main/java/io/reactivex/subjects/ReplaySubject.java 96.44% <ø> (-0.67%) 50% <ø> (-1%)
...ternal/operators/observable/ObservableFlatMap.java 82.78% <ø> (-0.67%) 3% <ø> (ø)
...ex/internal/operators/flowable/FlowableReplay.java 89.79% <ø> (-0.47%) 17% <ø> (ø)
...vex/internal/operators/parallel/ParallelRunOn.java 95.93% <ø> (ø) 6% <ø> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <ø> (ø) 5% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d3b0e...65b18ea. Read the comment docs.

@akarnokd akarnokd closed this Feb 3, 2017
@akarnokd akarnokd reopened this Feb 3, 2017
@akarnokd akarnokd merged commit 71cda3e into ReactiveX:2.x Feb 3, 2017
@akarnokd akarnokd deleted the SimpleQueueJavadoc branch February 3, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants