Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator GroupJoin v2 #565

Merged
merged 1 commit into from
Dec 5, 2013
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 5, 2013

Issue #53

Rebased.

Still: @headinthebox While writing the test for the operator, I've noticed that when both duration selectors are never(), Rx.NET never calls onCompleted on the group subjects, even though the left and right sources onComplete(). I haven't seen Rx.NET test for this scenario. This comes into play when I want to emulate join() with groupJoin(): the outer merge never onCompletes(). If I understand the behavior corretly, when both left and right sources get depleted, there is no way a new group or new group value would arrive, and all the open groups and the main observer can be onCompleted(). This is somewhat similar to join() and groupByUntil() behavior.

@cloudbees-pull-request-builder

RxJava-pull-requests #493 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Dec 5, 2013
@benjchristensen benjchristensen merged commit 01f5c77 into ReactiveX:master Dec 5, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@akarnokd akarnokd deleted the GroupJoin2 branch January 13, 2014 10:03
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants