2.x: Improve JavaDoc of retryWhen() operators #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5773 +/- ##
============================================
- Coverage 96.24% 96.23% -0.02%
- Complexity 5811 5814 +3
============================================
Files 634 634
Lines 41607 41607
Branches 5770 5770
============================================
- Hits 40046 40041 -5
- Misses 629 632 +3
- Partials 932 934 +2
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Dec 21, 2017
| * Example: | ||
| * | ||
| * This retries 3 times, each time incrementing the number of seconds it waits. | ||
| * | ||
| * <pre><code> | ||
| * Publisher.create((Subscriber<? super String> s) -> { | ||
| * Flowable.create((Subscriber<? super String> s) -> { |
artem-zinnatullin
approved these changes
Dec 21, 2017
|
Spotted a few other mistakes in there. |
vanniktech
approved these changes
Dec 21, 2017
|
Just noticed, in the |
|
Indeed. Updated the PR and fixed the blockingX() calls in there as well. |
vanniktech
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Javadoc of the
retryWhenoperators in the 5 base classes, adds example to handling an asynchronous source with delay where an earlyonCompletemay cause unexpected terminations otherwise.Related: #5772.