Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Document replay(N) emission retention caveat #5828

Merged
merged 1 commit into from
Jan 31, 2018
Merged

2.x: Document replay(N) emission retention caveat #5828

merged 1 commit into from
Jan 31, 2018

Conversation

BenTilbrook
Copy link
Contributor

Adds javadocs indicating a caveat regarding size-bounded replay operators, subjects, and processors. See #5827 for details.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #5828 into 2.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5828      +/-   ##
============================================
- Coverage     96.44%   96.35%   -0.09%     
  Complexity     5817     5817              
============================================
  Files           634      634              
  Lines         41761    41761              
  Branches       5796     5796              
============================================
- Hits          40276    40239      -37     
- Misses          570      592      +22     
- Partials        915      930      +15
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 526 <0> (ø) ⬇️
...main/java/io/reactivex/subjects/ReplaySubject.java 97.33% <ø> (-0.23%) 49 <0> (ø)
.../java/io/reactivex/processors/ReplayProcessor.java 99.35% <ø> (ø) 51 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 91.03% <0%> (-4.94%) 60% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...internal/disposables/ArrayCompositeDisposable.java 96.42% <0%> (-3.58%) 15% <0%> (-1%)
...vex/internal/operators/single/SingleTakeUntil.java 91.8% <0%> (-3.28%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 61.8% <0%> (-2.78%) 35% <0%> (-2%)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8380e2...dfb43f6. Read the comment docs.

@akarnokd akarnokd merged commit 421b9a4 into ReactiveX:2.x Jan 31, 2018
@akarnokd akarnokd added this to the 2.2 milestone Jan 31, 2018
@BenTilbrook BenTilbrook deleted the improve-replay-javadocs branch January 31, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants