Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marble diagram for Single.hide operator #6077

Merged
merged 2 commits into from
Jul 12, 2018

Conversation

UMFsimke
Copy link
Contributor

@UMFsimke UMFsimke commented Jul 8, 2018

This should complete hide operator in #5788

Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.

Although I wasn't sure if I should represent somehow that Disposable is hidden as well. If so, can you please tell me how to represent that on marble?

@codecov
Copy link

codecov bot commented Jul 8, 2018

Codecov Report

Merging #6077 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6077      +/-   ##
============================================
+ Coverage     98.26%   98.26%   +<.01%     
  Complexity     6192     6192              
============================================
  Files           666      666              
  Lines         44806    44806              
  Branches       6206     6206              
============================================
+ Hits          44028    44029       +1     
- Misses          236      237       +1     
+ Partials        542      540       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.44% <0%> (-1.71%) 11% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 95.21% <0%> (-1.07%) 3% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 94.89% <0%> (-0.73%) 2% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 86.58% <0%> (-0.64%) 3% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a9852...1c179ae. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Jul 9, 2018
@@ -1875,6 +1875,8 @@
/**
* Hides the identity of the current Single, including the Disposable that is sent
* to the downstream via {@code onSubscribe()}.
* <p>
* <img width="640" height="470" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Hide.png" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a different superhero(ine) per reactive type who is relatively recognizable from the stylized head and doesn't require complicated drawings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

@UMFsimke
Copy link
Contributor Author

UMFsimke commented Jul 9, 2018

I dont get it, why is CI failing. I've run tests locally and I dont get that error which CI is reporting.

@akarnokd
Copy link
Member

akarnokd commented Jul 9, 2018

Sometimes CI is a bit noisy and some of our millisecond-level tests can fail. I've restarted the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants