Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Final set of missing Completable marbles (+26) #6101

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

akarnokd
Copy link
Member

This PR contains the final set of missing Completable marbles (#5789):

repeat

image
image


repeatUntil

image


repeatWhen

image


retry

image
image
image
image
image


retryWhen

image


startWith

image
image
image


timeout

image
image
image
image


create

image


unsafeCreate

image


lift

image


subscribe

image
image
image


subscribeWith

image


test

image
image

@akarnokd akarnokd added this to the 2.2 milestone Jul 20, 2018
@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #6101 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6101      +/-   ##
===========================================
- Coverage     98.3%   98.29%   -0.02%     
  Complexity    6197     6197              
===========================================
  Files          667      667              
  Lines        44862    44862              
  Branches      6213     6213              
===========================================
- Hits         44100    44095       -5     
- Misses         228      230       +2     
- Partials       534      537       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (ø) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 93.46% <0%> (-2.62%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-0.97%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5119c...7282477. Read the comment docs.

@akarnokd akarnokd merged commit f4a18fd into ReactiveX:2.x Jul 20, 2018
@akarnokd akarnokd deleted the CompletableMarblesFinal0720 branch July 20, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants