Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc: fix examples using markdown instead of @code #6346

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

akarnokd
Copy link
Member

In javadoc, backtick has no meaning and caused javadoc compilation errors:

https://travis-ci.org/akarnokd/RxJava2_9/jobs/469904725#L516

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #6346 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6346      +/-   ##
============================================
- Coverage     98.27%   98.26%   -0.02%     
+ Complexity     6285     6283       -2     
============================================
  Files           672      672              
  Lines         44992    44992              
  Branches       6223     6223              
============================================
- Hits          44218    44212       -6     
- Misses          244      245       +1     
- Partials        530      535       +5
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
...ternal/operators/observable/ObservablePublish.java 94.69% <0%> (-3.54%) 11% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 93.61% <0%> (-2.66%) 3% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ex/internal/operators/flowable/FlowableCreate.java 95.8% <0%> (-1.94%) 6% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-1.5%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 97.02% <0%> (-1.28%) 11% <0%> (+1%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc40695...cae77cb. Read the comment docs.

@akarnokd akarnokd merged commit 5aef7fe into ReactiveX:2.x Dec 24, 2018
@akarnokd akarnokd deleted the JavadocFix1219 branch December 24, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants