Fix bug in CompositeException.getRootCause #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code use to be `if (root == null || root == e)`, but apparently after some refactoring it ended up as `if (root == null || cause == root)`, which I believe is a bug. This method should probably be `static` (that would have prevented the bug).
Codecov Report
@@ Coverage Diff @@
## 2.x #6380 +/- ##
============================================
+ Coverage 98.25% 98.28% +0.02%
+ Complexity 6292 6290 -2
============================================
Files 673 673
Lines 45092 45092
Branches 6239 6239
============================================
+ Hits 44306 44317 +11
+ Misses 248 241 -7
+ Partials 538 534 -4
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Jan 21, 2019
| @@ -280,7 +280,7 @@ public int size() { | |||
| */ | |||
| /*private */Throwable getRootCause(Throwable e) { | |||
There was a problem hiding this comment.
I think you should go ahead and make it static
There was a problem hiding this comment.
Oops, already merged.
akarnokd
approved these changes
Jan 21, 2019
vanniktech
approved these changes
Jan 21, 2019
guillermocalvo
added a commit
to guillermocalvo/RxJava
that referenced
this pull request
Jan 21, 2019
* Fix bug in CompositeException.getRootCause The original code use to be `if (root == null || root == e)`, but apparently after some refactoring it ended up as `if (root == null || cause == root)`, which I believe is a bug. This method should probably be `static` (that would have prevented the bug). * Update unit tests for CompositeException.getRootCause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found what I believe is a bug in
CompositeException.getRootCause.The original code use to be
if (root == null || root == e), but apparently after some refactoring it ended up asif (root == null || cause == root).As a side note, I think this method should be made
static(that would have prevented the bug).