Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant methods from Sample(Observable) #6469

Merged
merged 6 commits into from
Apr 26, 2019
Merged

Remove redundant methods from Sample(Observable) #6469

merged 6 commits into from
Apr 26, 2019

Conversation

lxsmnsyc
Copy link

@lxsmnsyc lxsmnsyc commented Apr 26, 2019

Resolves: #6468

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #6469 into 2.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6469      +/-   ##
============================================
+ Coverage     98.26%   98.29%   +0.03%     
+ Complexity     6295     6291       -4     
============================================
  Files           675      675              
  Lines         45173    45159      -14     
  Branches       6246     6244       -2     
============================================
+ Hits          44388    44390       +2     
+ Misses          247      240       -7     
+ Partials        538      529       -9
Impacted Files Coverage Δ Complexity Δ
...al/operators/flowable/FlowableSamplePublisher.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ors/observable/ObservableSampleWithObservable.java 98.68% <100%> (-0.12%) 3 <0> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.23% <0%> (-2.42%) 2% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...internal/operators/flowable/FlowableSwitchMap.java 95.28% <0%> (-1.42%) 3% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deeb141...308f7d0. Read the comment docs.

@akarnokd akarnokd changed the title Fix issue #6468 Remove redundant methods from Sample(Observable), Javadoc mistake fixes Apr 26, 2019
@akarnokd akarnokd added this to the 2.2 backlog milestone Apr 26, 2019
@akarnokd
Copy link
Member

Could you also check Flowable.sample(Flowable)?

@lxsmnsyc
Copy link
Author

Could you also check Flowable.sample(Flowable)?

I'll check into it

@lxsmnsyc
Copy link
Author

done with the Flowable.sample

@akarnokd akarnokd changed the title Remove redundant methods from Sample(Observable), Javadoc mistake fixes Remove redundant methods from Sample(Observable) Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableSampleWithObservable redundant methods
3 participants