Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused else from the Observable #6485

Merged
merged 2 commits into from
May 23, 2019
Merged

remove unused else from the Observable #6485

merged 2 commits into from
May 23, 2019

Conversation

VovaStelmashchuk
Copy link
Contributor

Remove unused else from the Observable class.

import org.reactivestreams.Publisher;

import io.reactivex.annotations.*;
import java.util.Collection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not unroll star imports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor Author

@VovaStelmashchuk VovaStelmashchuk May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarnokd Maybe you can include some rule for the import bloc to CONTRIBUTING.md ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordan1997

When submitting code, please make every effort to follow existing conventions and style in order to keep the code as readable as possible.

But don't worry, we will warn you if there is a stylistic problem.

@akarnokd akarnokd added this to the 2.2 backlog milestone May 23, 2019
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #6485 into 2.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6485      +/-   ##
============================================
- Coverage     98.28%   98.24%   -0.05%     
+ Complexity     6297     6294       -3     
============================================
  Files           675      675              
  Lines         45159    45159              
  Branches       6244     6244              
============================================
- Hits          44384    44365      -19     
- Misses          243      248       +5     
- Partials        532      546      +14
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 542 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 85.62% <0%> (-6.54%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...activex/internal/schedulers/ExecutorScheduler.java 95.97% <0%> (-2.02%) 10% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f51d2d...3d11cb8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants