Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix zip not stopping the subscription upon eager error #6488

Merged
merged 1 commit into from
May 27, 2019

Conversation

akarnokd
Copy link
Member

The Observable.zip did not stop subscribing to the next sources if the previous one failed with an onError. Flowable.zip works as intended.

Fixes #6487

@akarnokd akarnokd added this to the 2.2 backlog milestone May 26, 2019
@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #6488 into 2.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6488      +/-   ##
============================================
- Coverage     98.26%   98.25%   -0.02%     
- Complexity     6297     6298       +1     
============================================
  Files           675      675              
  Lines         45159    45163       +4     
  Branches       6244     6244              
============================================
- Hits          44374    44373       -1     
- Misses          244      247       +3     
- Partials        541      543       +2
Impacted Files Coverage Δ Complexity Δ
...x/internal/operators/observable/ObservableZip.java 100% <100%> (ø) 6 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 94.69% <0%> (-3.54%) 11% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-2.68%) 5% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...internal/operators/flowable/FlowableSwitchMap.java 95.28% <0%> (-1.42%) 3% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.36% <0%> (-1.07%) 9% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.78% <0%> (-0.97%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca7a9b...a1bdaf6. Read the comment docs.

@akarnokd akarnokd merged commit c415b32 into ReactiveX:2.x May 27, 2019
@akarnokd akarnokd deleted the ZipErrorCancelFix branch May 27, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple errors in zip'ed observables with flatMap
2 participants