Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Various small API changes and removals #6517

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

akarnokd
Copy link
Member

  • Maybe.defaultIfEmpty() returns Single.
  • Removal of Maybe.toSingle(T).
  • Removal of Flowable.subscribe(4 args)
  • Removal of Observable.subscribe(4 args)
  • Removal of Single.toCompletable()
  • Removal of Completable.blockingGet()
  • Removal of Flowable.subscribe(/* 4 args */)
  • Removal of Observable.subscribe(/* 4 args */)

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #6517 into 3.x will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6517      +/-   ##
============================================
+ Coverage     98.12%   98.19%   +0.07%     
+ Complexity     6250     6245       -5     
============================================
  Files           675      675              
  Lines         45083    45051      -32     
  Branches       6226     6225       -1     
============================================
+ Hits          44236    44237       +1     
+ Misses          293      274      -19     
+ Partials        554      540      -14
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (-2) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 147 <0> (-1) ⬇️
...ivex/internal/observers/BlockingMultiObserver.java 100% <ø> (ø) 19 <0> (-5) ⬇️
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 565 <3> (-1) ⬇️
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 540 <3> (-1) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <100%> (ø) 171 <0> (-1) ⬇️
...rnal/operators/observable/ObservableSwitchMap.java 93.61% <0%> (-1.07%) 3% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.36% <0%> (-1.07%) 9% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
.../operators/mixed/FlowableConcatMapCompletable.java 99.14% <0%> (-0.86%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40087e9...f511469. Read the comment docs.

@akarnokd akarnokd merged commit 583c4e7 into ReactiveX:3.x Jun 19, 2019
@akarnokd akarnokd deleted the SignatureChangesNRemovals3x branch June 19, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant