Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add missing marble diagams to Single #6668

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

akarnokd
Copy link
Member

Add (hopefully) all remaining missing marble diagrams to Single.

Resolves #5788

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@akarnokd akarnokd added this to the 3.0 milestone Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #6668 into 3.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               3.x    #6668      +/-   ##
===========================================
+ Coverage     98.1%   98.12%   +0.01%     
  Complexity    6187     6187              
===========================================
  Files          677      677              
  Lines        44682    44682              
  Branches      6169     6169              
===========================================
+ Hits         43837    43843       +6     
+ Misses         303      299       -4     
+ Partials       542      540       -2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 148 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.09% <0%> (-6.35%) 2% <0%> (ø)
...rxjava3/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.14% <0%> (-2.09%) 2% <0%> (ø)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...reactivex/rxjava3/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
...a3/internal/operators/flowable/FlowableReplay.java 91.97% <0%> (-0.83%) 19% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 94.36% <0%> (-0.71%) 2% <0%> (ø)
...internal/operators/flowable/FlowableObserveOn.java 97.49% <0%> (+0.27%) 3% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7ff83...ecfedfd. Read the comment docs.

@akarnokd akarnokd merged commit e6406b3 into ReactiveX:3.x Oct 11, 2019
@akarnokd akarnokd deleted the SingleMarbles3x branch October 11, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Single incorrect or missing images (tracking issue)
2 participants