Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix Observable.window (size, skip, overlap) dispose behavior #7049

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Aug 4, 2020

Disposing the main output of the Observable.window operator did not properly propagate the dispose call under certain circumstances, such as no current active window or the window(s) were abandoned immediately.

Fixes #7048

@akarnokd akarnokd added this to the 3.1 milestone Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #7049 into 3.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7049      +/-   ##
============================================
- Coverage     99.52%   99.51%   -0.02%     
+ Complexity     6669     6667       -2     
============================================
  Files           742      742              
  Lines         47273    47275       +2     
  Branches       6374     6374              
============================================
- Hits          47048    47045       -3     
- Misses          105      107       +2     
- Partials        120      123       +3     
Impacted Files Coverage Δ Complexity Δ
...nternal/operators/observable/ObservableWindow.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../internal/disposables/ListCompositeDisposable.java 98.00% <0.00%> (-2.00%) 34.00% <0.00%> (-1.00%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0.00%> (-1.86%) 39.00% <0.00%> (-1.00%)
...ternal/operators/observable/ObservablePublish.java 97.29% <0.00%> (-1.81%) 16.00% <0.00%> (-1.00%)
...a3/internal/operators/flowable/FlowableCreate.java 97.08% <0.00%> (-1.62%) 6.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
...ternal/operators/observable/ObservableGroupBy.java 98.90% <0.00%> (-1.10%) 2.00% <0.00%> (ø%)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0.00%> (-0.91%) 2.00% <0.00%> (ø%)
...nternal/operators/observable/ObservableCreate.java 99.14% <0.00%> (-0.86%) 2.00% <0.00%> (ø%)
.../operators/observable/ObservableCombineLatest.java 99.38% <0.00%> (-0.62%) 6.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fcaf0...bf081d5. Read the comment docs.

@akarnokd akarnokd merged commit 7ed8e1a into ReactiveX:3.x Aug 6, 2020
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whops. Somehow missed this 👍

@akarnokd akarnokd deleted the ObservableWindowFix3x branch August 6, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Observable.window() operators do not dispose upstream while there is an active window
2 participants