Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: fromRunnable/fromAction javadoc improvements #7071

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

akarnokd
Copy link
Member

  • Fix the wording across the base types.
  • Add missing error handling section.
  • Point to fromAction in fromRunnable docs.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #7071 into 3.x will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7071      +/-   ##
============================================
- Coverage     99.55%   99.51%   -0.05%     
  Complexity     6669     6669              
============================================
  Files           742      742              
  Lines         47275    47275              
  Branches       6374     6374              
============================================
- Hits          47066    47045      -21     
- Misses           96      105       +9     
- Partials        113      125      +12     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/reactivex/rxjava3/core/Completable.java 100.00% <ø> (ø) 140.00 <0.00> (ø)
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø) 595.00 <0.00> (ø)
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100.00% <ø> (ø) 214.00 <0.00> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø) 565.00 <0.00> (ø)
...eactivex/rxjava3/processors/BehaviorProcessor.java 97.48% <0.00%> (-2.52%) 50.00% <0.00%> (ø%)
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-2.39%) 2.00% <0.00%> (ø%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.34% <0.00%> (-2.33%) 2.00% <0.00%> (ø%)
.../internal/disposables/ListCompositeDisposable.java 98.00% <0.00%> (-2.00%) 34.00% <0.00%> (-1.00%)
...a3/internal/operators/flowable/FlowableCreate.java 97.41% <0.00%> (-1.62%) 6.00% <0.00%> (ø%)
...ternal/operators/observable/ObservableGroupBy.java 98.90% <0.00%> (-1.10%) 2.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15b5a5...7c45b86. Read the comment docs.

@akarnokd akarnokd merged commit 0f21ba8 into ReactiveX:3.x Sep 12, 2020
@akarnokd akarnokd deleted the JavadocCorrections911a branch September 12, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant