Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization framework #54

Closed
NiteshKant opened this issue Feb 26, 2014 · 4 comments
Closed

Serialization framework #54

NiteshKant opened this issue Feb 26, 2014 · 4 comments

Comments

@NiteshKant
Copy link
Member

This is a blanket issue for serialization/deserialization.

@spencergibb
Copy link

Anything I can do to help here? I'd like to integrate https://github.com/Netflix/ribbon 2.0 into https://github.com/spring-cloud/spring-cloud-netflix/ but ribbon 2.0 is waiting on serialization in RxNetty.

@NiteshKant
Copy link
Member Author

@spencergibb we are still discussing the design and feature of the serialization support for RxNetty from Netflix's perspective. Once the thoughts are a bit more concrete, I intent to create issues here that can be discussed. I hope that will give you more context on what we are trying to achieve and hence will be more fruitful if you wish to contribute.

BTW, when you say "ribbon 2.0 is waiting on serialization in RxNetty." you mean that ribbon can not be used for anything else but reading/writing ByteBuf, correct?

@spencergibb
Copy link

@NiteshKant thanks for the update. You are correct. In ribbon 2.0 there in an exception thrown in HttpRequest.java#L90 if the RibbonResponse type is anything other than ByteBuf.

I'd be interested in the plugability of the API. With Feign I was able to plug into Spring's MessageConverter framework. See SpringDecoder.java and SpringEncoder.java for examples.

It seems like the Ribbon 2.0 annotations would replace Feign (for our purposes), which is why I was interested and bubbled this up.

I see there is a framework for transforming content into a ByteBuf in ContentTransformer. Would this new framework be the opposite, taking a ByteBuf and returning an arbitrary Object?

@NiteshKant
Copy link
Member Author

At Netflix we have decided to move serialization/deserialization out of the scope of RxNetty as it can easily be layered on top. Moreover, there is less value in standardizing the formats as YMMV!

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants