Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.0 support #1414

Closed
swftvsn opened this issue Sep 20, 2017 · 12 comments
Closed

Swift 4.0 support #1414

swftvsn opened this issue Sep 20, 2017 · 12 comments

Comments

@swftvsn
Copy link

swftvsn commented Sep 20, 2017

Would be awesome! Is there any work done on this?

@nmdias
Copy link

nmdias commented Sep 20, 2017

There is a swift4.0 branch.

I didn't had any issues with Swift 4 & Xcode 9 on my end. It's working great. I also don't remember needing to specify that branch... 🤔

@groue
Copy link

groue commented Sep 20, 2017

I think the swift4.0 branch has been superseded by beta releases such as 4.0.0-beta.0:

tweet:

I've published 4.0.0-beta.0 this morning at ~ 2:00AM

tweet:

We are planning to release 4.0 mid October, we are in beta right now.

But I'm not sure it's the correct way to go: the swift4.0 branch may have the same content as the 3.6.1 release + Swift 4 compatibility, when the 4.0.0-beta.0 tag may have breaking changes towards the future version 4.0.

@kzaher: it looks like the community could enjoy some "official" communication on Swift 4.

@tomisacat
Copy link

But RxCocoa currently does not support Swift 4

@kzaher
Copy link
Member

kzaher commented Sep 20, 2017

I've updated the README.md file with

Currently CHANGELOG.md represents official communication about releases.

## [4.0.0-alpha.0](https://github.com/ReactiveX/RxSwift/releases/tag/4.0.0-alpha.0)
* Swift 4.0 compatibility
* Changes delegate proxy to use plugin architecture. 

@zhentan
Copy link

zhentan commented Sep 22, 2017

It seems like iTunes Connect does not like having "4.0.0-beta.0" as the CFBundleShortVersionString value. When trying to upload my app via fastlane pilot I get the following error: [Transporter Error Output]: ERROR ITMS-90060: "This bundle is invalid. The value for key CFBundleShortVersionString '4.0.0-beta.0' in the Info.plist file must be a period-separated list of at most three non-negative integers." Has anyone else had this problem?

@Vkt0r
Copy link
Contributor

Vkt0r commented Sep 28, 2017

@zhentan Same issue here trying to submit a new build to TestFlight using the pre-release branch

@Vkt0r
Copy link
Contributor

Vkt0r commented Sep 28, 2017

@zhentan For the moment you can use this workaround if you're using Carthage https://github.com/AFNetworking/AFNetworking/issues/3092#issuecomment-150605547 or with Cocoapods you can use CocoaPods/CocoaPods#4421 (comment). I hope this help you for the moment

@kzaher
Copy link
Member

kzaher commented Oct 8, 2017

Hi,

4.0.0-rc.0 is out. We'll release this in a week unless we find some big issue.

If you see some issue with the public API or some functionality, next week is the time to report it :)

@Jenus
Copy link

Jenus commented Oct 12, 2017

Waiting and expecting for the coming big thing, haha!
Thanks for awesome job!

@SylvanasX
Copy link

Thanks for awesome job!

@AJ9UNiDAYS
Copy link

Any issues release 4.0.0 @kzaher ?

@kzaher
Copy link
Member

kzaher commented Oct 16, 2017

@AJ9UNiDAYS I'm doing some final checks and trying to figure out did I forget to fix some part. I'll publish it once I finish running tests. Hopefully today.

@kzaher kzaher closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants