Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PackageDescriptionV4 #1418

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Update to PackageDescriptionV4 #1418

merged 1 commit into from
Sep 21, 2017

Conversation

devxoul
Copy link
Contributor

@devxoul devxoul commented Sep 21, 2017 •
edited
Loading

swift4.0 branch seems to be disappeared 🤔

(this PR is even with #1413)

@devxoul devxoul requested a review from kzaher September 21, 2017 12:42
@RxPullRequestBot
Copy link

2 Warnings
⚠️ Please target PRs to develop branch
⚠️ No CHANGELOG changes made

Generated by 🚫 Danger

@kzaher
Copy link
Member

kzaher commented Sep 21, 2017

Hi @devxoul ,

we've renamed it to rxswift4.0-swift4.0 because we've received some complaints in #1414 .

@devxoul
Copy link
Contributor Author

devxoul commented Sep 21, 2017

Ah, I see 👍

@devxoul devxoul merged commit cb0fb3b into ReactiveX:rxswift4.0-swift4.0 Sep 21, 2017
@devxoul devxoul deleted the swift4.0 branch September 21, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzaher kzaher Awaiting requested review from kzaher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devxoul @RxPullRequestBot @kzaher