Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Swift 4.0 & Xcode 9.0 #201

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Upgrade to Swift 4.0 & Xcode 9.0 #201

merged 1 commit into from
Oct 12, 2017

Conversation

mohamede1945
Copy link
Collaborator

@mohamede1945 mohamede1945 commented Oct 9, 2017 •
edited

Fixes #199

Problem

  • Xcode 9 & Swift 4.0 are released and we don't support them.

Solution

  • Now we support Xcode 9 & Swift 4.0.
  • The main changes were in updating to latest pods as most of them supported Swift 4.0.
  • RxSwift hasn't created a new pod version yet for Swift 4.0. But should do it soon.
  • Changes to the app are minimal to support Swift 4.0.

Testing

  • Manual testing on an iPhone.
  • There might be some problems but those are due to iOS 11 SDK and should be addressed in a separate PR.

@mohamede1945 mohamede1945 mentioned this pull request Oct 9, 2017
Closed
@mohamede1945 mohamede1945 merged commit 2ea4f1c into master Oct 12, 2017
@mohamede1945 mohamede1945 deleted the swift4 branch October 12, 2017 00:33
@mohamede1945 mohamede1945 mentioned this pull request Oct 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mohamede1945