Fix RxExample and Playgrounds using Static Frameworks #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the build settings for the RxExample application targets and for the RxPlaygrounds dynamic framework target to work correctly with the static framework versions of the RxSwift, RxCocoa, and RxRelay frameworks.
I changed line 3 of RxPlaygrounds.swift from `// RxPlaygrounds` to `// RxExample` because of some build validation check.
I updated validate-playgrounds.sh to also build the RxPlaygrounds framework.
I revised my previous change to get validate-playgrounds.sh to build the RxPlaygrounds dynamic framework before attempting to build the playgrounds test application.
I revered the change that I made to the development team setting when building the RxExample application for testing the static library solution.
|
Thnx @freak4pc and @mfcollins3 . I've merged this through terminal, but GitHub didn't detect the merge since the target was |
|
FYI, you can always change the destination branch yourself @kzaher :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conversion: #1940 (comment)
This pull request fixes the
RxExamplesapplication andRxPlaygroundsdynamic framework so that they build correctly and run correctly.I also made a change to the
validate-playgrounds.shscript to build theRxPlaygroundsdynamic framework before attempting to build and run the playgrounds application.