[rx-lite] Passing a non-natural number to repeat causes infinite loop

[edorivai]

RxJS version:
rx-lite@4.0.8

Code to reproduce:

const Rx = require('rx-lite');

Rx.Observable.of(1)
	.repeat(2.5)
	.subscribe(i => console.log('onnext: ' + i));

Expected behavior:

Either throw an error, or repeat 2, or 3 times.

Actual behavior:

Repeats infinitely, logs:

onnext: 1
onnext: 1
onnext: 1
onnext: 1
...etc, infinitely

Additional information:

I understand that it doesn't make so much sense to pass a non natural number to repeat. In our case, the repeat count was calculated dynamically, which made it unclear that this was an issue.

[edorivai]

I realize this isn't a problem in later (or "non-lite") versions, just leaving this info here for future googlers.

[kwonoj]

Rx-lite is v4 at https://github.com/Reactive-Extensions/RxJS, this repo contains v5 and further.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.